-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail to link Go binary on 1.22 #171
Comments
FWIW, I can reproduce this with local execution as well, so this is not an RBE-related bug. |
There isn't much we can do but report this upstream somewhere. So I will offer some guidance on what to do next and close this issue. Please create a small test case case: a Go file and a specific |
Also, feel free to add the link to the task to this issue, so whoever is following have a trail. I will subscribe to whatever you register and keep an eye on. |
I think closing this would delegate the burden of troubleshooting to the user of the toolchain. For example: event though Zig toolchain is being used, in the action above, all I could see is
It's unclear to me, a user, how to map that and the Furthermore, I think this toolchain repo should consider upgrading rules_go dependency + go_sdk to verify the reported issue using the existing test suite and avoid regression. So if breakage is found in that process, the toolchain maintainer should investigate and potentially fix this issue instead of closing it prematurely. |
Hi @sluongng, have you come to any solution please? I have the same issue after upgrading to Go 1.22 |
We are weighing our options. Most likely we gonna stop using I am testing out https://github.com/bazel-contrib/toolchains_llvm/ with a custom sysroot as an alternative solution. But our problem is rather narrow and unique so folks will have to decide for themselves. |
Sorry about this, you were right. Reopening and will pin for higher visibility. |
Afaik if things are like they were a year ago Uber may have this problem too, since it uses musl for some targets. @linzhp have you upgraded to 1.22 yet? |
We are on 1.22.1, but we are using There is only one shell script using musl to compile a Cgo target, and it did fail with the same error, but I guess no one is calling that shell script... |
Change log: https://tip.golang.org/doc/go1.22 Since musl toolchain in --config=static is not compatible with the latest Go version, disable static workflows for now. Issue is reported in uber/hermetic_cc_toolchain#171
Change log: https://tip.golang.org/doc/go1.22 Since musl toolchain in --config=static is not compatible with the latest Go version, disable static workflows for now. Issue is reported in uber/hermetic_cc_toolchain#171
Example failure here https://app.buildbuddy.io/invocation/abd101b0-f5e3-4c5a-83ad-a459949a2905 with the remotely executed action here https://app.buildbuddy.io/invocation/abd101b0-f5e3-4c5a-83ad-a459949a2905?actionDigest=2141d6f2153f2060aef65156f6f74d66f2737bf6a25a818bb3e2419fb47c01b1%2F261&executeResponseDigest=77fe59ae3016c296887efe46b0b4d5c782385a865a92dc511672fd971ebf8947%2F127#action
Error message
On the surface, this looks like an incompatibility between Go 1.22 and
@zig_sdk//toolchain:linux_amd64_musl
like reported in golang/go#44695Additional info:
The text was updated successfully, but these errors were encountered: