zapslog: Apply callerSkip when addCaller #1380
Open
+5
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CallerSkip was added to the Handler but only used for the stacktrace, it should also be applied to the caller with an appropriate offset.
Currently the stacktrace can be correct for a wrapped logger but there is no way to fix the caller information.
Here is the equivalent logger functionality where the skip is applied for the caller:
zap/logger.go
Lines 393 to 414 in c17272e