Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zapgrpc: dependabot upgrade failed #1473

Open
arukiidou opened this issue Nov 28, 2024 · 0 comments · May be fixed by #1474
Open

zapgrpc: dependabot upgrade failed #1473

arukiidou opened this issue Nov 28, 2024 · 0 comments · May be fixed by #1474

Comments

@arukiidou
Copy link
Contributor

arukiidou commented Nov 28, 2024 •
edited
Loading

Describe the bug

go: go.uber.org/zap/zapgrpc/internal/test tested by
	go.uber.org/zap/zapgrpc/internal/test.test imports
	github.com/stretchr/testify/assert loaded from github.com/stretchr/[email protected],
	but go 1.16 would select v1.8.3
go: go.uber.org/zap/zapgrpc/internal/test tested by
	go.uber.org/zap/zapgrpc/internal/test.test imports
	github.com/stretchr/testify/require loaded from github.com/stretchr/[email protected],
	but go 1.16 would select v1.8.3
go: go.uber.org/zap/zapgrpc/internal/test tested by
	go.uber.org/zap/zapgrpc/internal/test.test imports
	github.com/stretchr/testify/assert imports
	gopkg.in/yaml.v3 tested by
	gopkg.in/yaml.v3.test imports
	gopkg.in/check.v1 imports
	github.com/kr/pretty imports
	github.com/rogpeppe/go-internal/fmtsort loaded from github.com/rogpeppe/[email protected],
	but go 1.16 would select v1.9.0

To upgrade to the versions selected by go 1.16:
	go mod tidy -go=1.16 && go mod tidy -go=1.17
If reproducibility with go 1.16 is not needed:
	go mod tidy -compat=1.17
For other options, see:
	https://golang.org/doc/modules/pruning
go: go.uber.org/zap/zapgrpc/internal/test tested by
	go.uber.org/zap/zapgrpc/internal/test.test imports
	github.com/stretchr/testify/assert loaded from github.com/stretchr/[email protected],
	but go 1.16 would select v1.8.3
go: go.uber.org/zap/zapgrpc/internal/test tested by
	go.uber.org/zap/zapgrpc/internal/test.test imports
	github.com/stretchr/testify/require loaded from github.com/stretchr/[email protected],
	but go 1.16 would select v1.8.3
go: go.uber.org/zap/zapgrpc/internal/test tested by
	go.uber.org/zap/zapgrpc/internal/test.test imports
	github.com/stretchr/testify/assert imports
	gopkg.in/yaml.v3 tested by
	gopkg.in/yaml.v3.test imports
	gopkg.in/check.v1 imports
	github.com/kr/pretty imports
	github.com/rogpeppe/go-internal/fmtsort loaded from github.com/rogpeppe/[email protected],
	but go 1.16 would select v1.9.0
make: *** [Makefile:[36](https://github.com/arukiidou/zap/actions/runs/12059977790/job/33629551328?pr=10#step:5:37): tidy-lint] Error 1

To Reproduce
upgrade to google.golang.org/grpc v1.56.3

Expected behavior
dependabot upgrade passed.

Additional context
go.mod not mached
@arukiidou arukiidou linked a pull request Nov 28, 2024 that will close this issue
Open
JacobOaks added a commit to JacobOaks/zap that referenced this issue Dec 10, 2024
@JacobOaks
Upgrade grpc in zapgrc test package & bump go version
5001440 
The dependabot PR uber-go#1376 fails to bump grpc due to conflict with go1.16 (ref: uber-go#1473).

Bump go version by one so go mod tidy is happy in the test package
with the grpc upgrade.
@JacobOaks JacobOaks mentioned this issue Dec 10, 2024
Merged
JacobOaks added a commit that referenced this issue Dec 10, 2024
@JacobOaks
Upgrade grpc in zapgrc test package & bump go version (#1478)
fe16eb5 
The dependabot PR #1376 fails to bump grpc due to conflict with go1.16
(ref: #1473).

Bump go version by one so go mod tidy is happy in the test package with
the grpc upgrade.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build(deps): Bump google.golang.org/grpc from to v1.64.1 in /zapgrpc arukiidou/zap
1 participant
@arukiidou