Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider use of t.Cleanup in goleak #53

Open
prashantv opened this issue Oct 27, 2020 · 1 comment
Open

Consider use of t.Cleanup in goleak #53

prashantv opened this issue Oct 27, 2020 · 1 comment
Assignees
@sywhang

Comments

@prashantv
Copy link
Collaborator

Within a test, the recommendation is to use defer goleak.VerifyNone(t). However, this can't be used inside of a test helper. We may want to support t.Cleanup, possibly via a new method, so this issue is to investigate what we should do.
@sywhang sywhang self-assigned this Jan 10, 2023
@Manik2708 Manik2708 mentioned this issue Dec 10, 2024
Merged
4 tasks
@Manik2708
Copy link

How about wrapping the VerifyNone inside t.CleanUp? We don't even need to defer VerifyNone! @sywhang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sywhang sywhang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@prashantv @sywhang @Manik2708