Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mountpoint multiple match #42

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

coco-roll
Copy link

When use make test base on this case
8 5 0:7 /docker /sys/fs/cgroup/memory rw,nosuid,nodev,noexec,relatime shared:8 - cgroup cgroup rw,memory 9 5 0:8 /docker/memory.vmstat /sys/fs/cgroup/vmstat rw,nosuid,nodev,noexec,relatime shared:8 - cgroup cgroup rw,memory
been failed.

Because it's match multiple target,cannot uniquely match

@CLAassistant
Copy link

CLAassistant commented Aug 5, 2021

CLA assistant check
All committers have signed the CLA.

@coco-roll
Copy link
Author

fix #41

@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.01%. Comparing base (0180b04) to head (57563fa).
Report is 27 commits behind head on master.

Files with missing lines Patch % Lines
internal/cgroups/mountpoint.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage   92.07%   91.01%   -1.06%     
==========================================
  Files           8        8              
  Lines         164      167       +3     
==========================================
+ Hits          151      152       +1     
- Misses         10       11       +1     
- Partials        3        4       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@coco-roll
Copy link
Author

Why Go / build (1.16.x) (pull_request) Failing?
I was run: make test and make lint all passed
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants