Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should ManagerAbsenceDao be ManagedAbsenceDao? Ditto ManagerTimeDao? #7

Open
apetro opened this issue Dec 16, 2013 · 0 comments
Open

Should ManagerAbsenceDao be ManagedAbsenceDao? Ditto ManagerTimeDao? #7

apetro opened this issue Dec 16, 2013 · 0 comments
Milestone
1.0.0-GA

Comments

@apetro
Copy link
Contributor

apetro commented Dec 16, 2013

ManagerAbsenceDao is a dao about ManagedAbsences. So, was it meant to be ManagedAbsenceDao, or more importantly, would that be a clearer name to give it going forward? Likewise with ManagerTimeDao being about ManagedTime objects.

Good to clarify this before a 1.0 GA release so as to stabilize the API.
apetro pushed a commit to apetro/hrs-portlets that referenced this issue Sep 23, 2014
@vertein
Merge pull request uPortal-Attic#7 from UW-Madison-DoIT/benefit_enrol…
1f0dc5c 
…lment_message

HRSPLT-163 : Update benefit enrollment message in benefit information portlet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0-GA
Development

No branches or pull requests
1 participant
@apetro