Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

my.diia.gov.ua: breakage #26604

Closed
11 tasks done
Mystic-Mirage opened this issue Dec 24, 2024 · 9 comments
Closed
11 tasks done

my.diia.gov.ua: breakage #26604

Mystic-Mirage opened this issue Dec 24, 2024 · 9 comments
Labels
uBOL Specific to uBlock Origin Lite

Comments

@Mystic-Mirage
Copy link

Prerequisites

  • This is NOT a YouTube, Facebook, Twitch or a shortener/hosting site report. These sites MUST be reported by clicking their respective links.
  • I read and understand the policy about what is a valid filter issue.
  • I verified that this issue is not a duplicate. (Use this button to find out.). Comment in the old issue threads even when they are closed or even if you have a different problem.
  • I did not remove any of the default filter lists, or I have verified that the issue was not caused by removing any of the default lists.
  • I did not enable additional filter lists, or I have verified that the issue still occurs without enabling additional filter lists.
  • I am not using uBO Lite along with other content blockers.
  • I have verified that the issue still exists after using the Complete filtering mode.
  • I have verified that the web browser's built-in content blocker/tracking protection, network wide/DNS blocking, or my VPN is not causing the issue.
  • I have verified that other extensions are not causing the issue.
  • If this is about a breakage or detection, I have verified that it is caused by uBOL Lite and isn't a site issue.
  • I did not answer truthfully to ALL the above checkboxes.

URL address of the web page

http://my.diia.gov.ua/

Category

breakage

Description

Ukrainian Filters seem broken for multiple websites including government and banking

Other extensions used

none

Screenshot(s)

image

Configuration

version: uBOL 2024.12.23.23
mode: complete / complete
rulesets:
 default
 urlhaus.full
 openphish.domains
 ukr-0
@stephenhawk8054
Copy link
Member

stephenhawk8054 commented Dec 24, 2024

@gorhill Not sure if it's caused by this filter?

diia*.*/$document,domain=~gov.ua|~diiacityunited.org|~fedoriv.com|~spivdiia.com|~spivdiia.org.ua

https://github.com/ukrainianfilters/lists/blob/e1a7a8cd80d83af8dee069ab754b82be9d4f74c8/combined/uBO/uBO.txt#L2506

due to doc and domain in DNR.

@serhiyguryev
Copy link

serhiyguryev commented Dec 24, 2024

As I've already mentioned here, the rules for the above-mentioned sites (web.monobank.ua and my.diia.gov.ua) work without any problems in Google Chrome using uBlock Origin (Manifest V2). Therefore, the problem appears only in the Lite version of the extension.

The patterns for the rules are optimized in terms of excluding situations where the names diia or monobank are used not in the domain name, but in the name of, for example, a website page.

@stephenhawk8054
Copy link
Member

@serhiyguryev I think it's due to MV3 DNR's understanding of initiator when using document and domain is different to uBO: uBlockOrigin/uBOL-home#156 (comment)

So currently for all the filters that have document, you can use to instead of domain.

@gorhill
Copy link
Member

gorhill commented Dec 24, 2024

The rule being triggered is:

{
  "action": {
    "type": "block"
  },
  "condition": {
    "excludedInitiatorDomains": [
      "diiacityunited.org",
      "fedoriv.com",
      "gov.ua",
      "spivdiia.com",
      "spivdiia.org.ua"
    ],
    "resourceTypes": [
      "main_frame"
    ],
    "urlFilter": "diia*.*/"
  },
  "id": 41,
  "priority": 10
}

So it looks like for document type, the rule should use excludedRequestDomains.


you can use to instead of domain

Rght, this would also solve the issue without code change, as to map to requestDomains/excludedRequestDomains.

@serhiyguryev
Copy link

What should this rule look like, so that it can be processed in the Lite version without any problems?

diia*.*/$document,domain=~gov.ua|~diiacityunited.org|~fedoriv.com|~spivdiia.com|~spivdiia.org.ua
=>
diia*.*/$document,to=~gov.ua|~diiacityunited.org|~fedoriv.com|~spivdiia.com|~spivdiia.org.ua

@stephenhawk8054
Copy link
Member

stephenhawk8054 commented Dec 24, 2024

Yes, that is correct:

 diia*.*/$document,to=~gov.ua|~diiacityunited.org|~fedoriv.com|~spivdiia.com|~spivdiia.org.ua

@serhiyguryev
Copy link

Thanks for the advice! Today we will update the rules so that they are processed correctly in the Lite version

@gorhill
Copy link
Member

gorhill commented Dec 24, 2024

Looks like we have been using to= instead of domain= in our own lists, so I will say it is the proper fix, changing the code to guess excludedInitiatorDomains should be replaced with excludedRequestDomains is not realistically feasible, this could lead to other sort of breakage, especially when document is used with other resource types.

@gorhill
Copy link
Member

gorhill commented Dec 24, 2024

Meanwhile until a new version of uBOL is published, the workaround is to toggle the site to no-filtering.

serhiyguryev added a commit to ukrainianfilters/lists that referenced this issue Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
uBOL Specific to uBlock Origin Lite
Projects
None yet
Development

No branches or pull requests

4 participants