Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newer versions are missing from releases #11

Open
IzzySoft opened this issue Jul 9, 2023 · 13 comments
Open

Newer versions are missing from releases #11

IzzySoft opened this issue Jul 9, 2023 · 13 comments

Comments

@IzzySoft
Copy link

IzzySoft commented Jul 9, 2023

I see there were recent releases on Google Play (6/2023), while the last release here on Github is one year old. Will you make newer versions available here, too? That would be especially useful to those of us who have no ties to Google at all (de-googled devices) and/or prefer not to use Google Play (e.g. for privacy reasons).

@IzzySoft
Copy link
Author

@tzebrowski any word?

@tzebrowski
Copy link
Owner

hi @IzzySoft,

Sure, next planned release to Google Play, will be also published on Github.

@IzzySoft
Copy link
Author

Wonderful, thanks! As the less wonderful news is the date for the delivery of my car was postponed again, I can have some more patience 🙈 Hopefully you'll be attaching the APKs then?

@IzzySoft
Copy link
Author

Oh, cool: I see the first beta was just published with an APK attached while I wrote the previous comment, thanks! Two questions on it:

package: name='org.obd.graphs.app' versionCode='1' versionName='1-20220717.1550'

Will you remember to increase versionCode with each release, so Android sees newer ones as updates? Otherwise it thinks it already has the latest version.

Offending libs:
---------------
* Metrics (/com/codahale/metrics): Tracking

1 offenders.

Is tracking on by default? Can it be turned off?

@tzebrowski
Copy link
Owner

Here is the clone of the first production google play release: https://github.com/tzebrowski/ObdGraphs/releases/tag/v74
wersionCode is increased each google release, otherwise google rejects artifacts.
When it comes to /com/codahale/metrics, its used for the implementation of rate collector https://github.com/tzebrowski/ObdMetrics/blob/main/src/main/java/org/obd/metrics/diagnostic/DefaultRateCollector.java, cannot be dropped or turn off,

@IzzySoft
Copy link
Author

wersionCode is increased each google release, otherwise google rejects artifacts.

Right, Google would reject an update with a versionCode it already has. I just wonder why the APK attached to the release still has it at 1 – it's not the first release, and build.gradle has much higher ones (18 resp. 54 / 74 currently) as well.

As for Codahale, what exactly does it do? According to the library data of my checker it's marked Tracking, which implies data is transferred off-device to some 3rd party without the explicit consent of the user ("cannot be dropped or turned off" means there is no expressive consent). Maybe the Tracking definition is wrong – but their devs themselves describe the lbrary as "gives you unparalleled insight into what your code does in production", so it's not functional (i.e. not needed for the app to work) but analytical. TL;DR: what you write sounds like it's just used internally (like getting metrics from the car into the app, without transferring it "elsewhere"). Is that correct? Apologies if I might sound a little stupid, but not being an Android dev I'm not "fluent" in reading source code 😉

@tzebrowski
Copy link
Owner

Right, Google would reject an update with a versionCode it already has. I just wonder why the APK attached to the release still has it at 1 – it's not the first release, and build.gradle has much higher ones (18 resp. 54 / 74 currently) as well.

Right, that's complex.. Under same project few apps are released to google play.. Anyway, application which is available here https://play.google.com/store/apps/details?id=org.obd.graphs.my.giulia has version 54 assigned, and can be found under Github releases (jar file) https://github.com/tzebrowski/ObdGraphs/releases/tag/v74

L;DR: what you write sounds like it's just used internally (like getting metrics from the car into the app, without transferring it "elsewhere"). Is that correct?

Correct.

@IzzySoft
Copy link
Author

Great, thanks! So to sum up:

  • thee APK at releases which currently has versionCode: 1 will have its versionCode increased with each new release
  • /com/codahale/metrics is only used locally to get the data from the car to the app
  • and I should rather stick to the one named OdbGraphs*release.apk and ignore the /^\d+\.apk$/as otherwise I indeed get a full load of trackers?

54.apk:

Offending libs:
---------------
* Metrics (/com/codahale/metrics): Tracking
* Crashlytics (/com/crashlytics): NonFreeComp,Tracking
* Google Ads (/com/google/ads): Ads,NonFreeComp
* Firebase Data Transport (/com/google/android/datatransport): NonFreeNet
* Google Mobile Services (/com/google/android/gms): NonFreeComp
* Firebase (/com/google/firebase): NonFreeNet,NonFreeComp
* Firebase Analytics (/com/google/firebase/analytics): NonFreeComp,Tracking
* Firebase Installations (/com/google/firebase/installations): NonFreeNet

8 offenders.

That would be a no-go for me and for those using my repo 😢 Can we stick to an APK without those (except the one we already clarified that is)?

@IzzySoft
Copy link
Author

IzzySoft commented Dec 3, 2023

@tzebrowski any chance this can be solved? Santa promised me 4 wheels, and I'm eager to give your app a try then 🤩

@IzzySoft
Copy link
Author

IzzySoft commented Jan 8, 2024

@tzebrowski apologies for nagging again, but as there's no answer yet… Do you plan for a "pure FOSS" version coming without those "8 offenders", or must I rather give up waiting? My 4 wheels are here, the OBD2 Adapter plugged in. But I wouldn't want to use any app with "techbro tracking" 😢

@IzzySoft
Copy link
Author

Either all my notifications are going to /dev/null – or no answer simply means "no". Is there a chance?

@tzebrowski
Copy link
Owner

I am dealing with different priorities, your request is "somewhere" on my list of TODOs, however not on the top, that's all, no hard feelings,
If you would like to, you can make a contribution to the project and send PR, I will approve,

@IzzySoft
Copy link
Author

Thanks! Then I'll have more patience. I'm no Android dev myself, so I unfortunately cannot help out on this with a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants