Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p + p margin #37

Open
l4u opened this issue Nov 24, 2014 · 1 comment
Open

p + p margin #37

l4u opened this issue Nov 24, 2014 · 1 comment

Comments

@l4u
Copy link

l4u commented Nov 24, 2014

<p>para1</p>
<p class="typl8-tera">para2</p>

the negative margin-top of the para2 becomes wrong because it is calculated according the the para2's size
https://github.com/typeplate/starter-kit/blob/v2.0.0/css/typeplate.css#L277

Should there be css rules like p.typl8-tera + p, p.typl8-giga + p, etc?

@grayghostvisuals
Copy link
Contributor

In terms of semantics, you should be using a heading level tag if you're truly trying to make a larger heading with text. You could also remove the declaration linked above (p + p) entirely and customize it for yourself.

This issue needs some time to breathe in order for me to decide the direction to go. Not really sure how I want to handle this ATM. Sit tight :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants