Rearchitect pulse mechanism #356
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolski
commented
Sep 22, 2021
| @@ -59,13 +59,27 @@ | |||
| import static org.junit.Assert.assertEquals; | |||
|
|
|||
| @SuppressWarnings("Duplicates") | |||
|
|
|||
| class ClientQueryTest2 { | |||
| @@ -45,8 +45,8 @@ def vaticle_dependencies(): | |||
| def vaticle_typedb_protocol(): | |||
| git_repository( | |||
| name = "vaticle_typedb_protocol", | |||
| remote = "https://github.com/vaticle/typedb-protocol", | |||
| commit = "3300d136a35f35bed58137bb79a6e3774dd170b9", # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_typedb_protocol | |||
| remote = "https://github.com/lolski/typedb-protocol", | |||
connection/TypeDBClientImpl.java
Outdated
| boolean alive; | ||
| try { | ||
| alive = stub().clientPulse(pulseReq(ID())).getAlive(); | ||
| System.out.println("client pulse - alive: " + alive); |
There was a problem hiding this comment.
TODO: remove log statement
lolski
force-pushed
the
client-pulse
branch
from
2b71a2b
to
5df4e8a
Compare
lolski
changed the title
flyingsilverfin
force-pushed
the
master
branch
2 times, most recently
from
9de6052
to
5932aad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
We've moved the pulse mechanism from session to client. Architecturally it makes more sense - the pulse is a mechanism to detect liveness and it's the client that may crash or gets cut off from the network, not any particular individual session instance owned by the client.
What are the changes implemented in this PR?
createmethods with regular constructors