Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing prerelease version of VSCode extension? #775

Open
davidtaylorhq opened this issue Oct 29, 2024 · 2 comments
Open

Publishing prerelease version of VSCode extension? #775

davidtaylorhq opened this issue Oct 29, 2024 · 2 comments

Comments

@davidtaylorhq
Copy link

We're using the 'unstable' release of glint, and it works much better for us than the 'stable' version. However, to get things working in VSCode, we have to manually build & install the glint VSCode extension.

Would it be possible to publish a 'pre-release' version of the VSCode plugin, to make it easier for people to start experimenting with the Volar-based implementation?

Happy to help with getting the automation set up, but I'd need help from someone with the necessary VSCode-marketplace credentials.

@machty
Copy link
Contributor

machty commented Nov 14, 2024

@davidtaylorhq I'm not opposed to this, but could you share what issues you're running into using the stable VSCode Plugin with the unstable Glint LS? I've been using this configuration and there are few things like "Organize Imports" that don't work, but are there other showstoppers I'm unaware of?

@davidtaylorhq
Copy link
Author

Unfortunately I wasn't able to consistently reproduce it, but this is the kind of error we were seeing:

Glint encountered an error computing diagnostics for this file. This is likely a bug in Glint; please file an issue, including any code and/or steps to follow to reproduce the error.

Error: Debug Failure. False expression: Script kind should match provided ScriptKind:1 and sourceFile.scriptKind: 3, !entry: false
    at getDocumentRegistryEntry (/Users/david/discourse/discourse/node_modules/.pnpm/[email protected]/node_modules/typescript/lib/typescript.js:140976:11)
    at Object.releaseDocumentWithKey (/Users/david/discourse/discourse/node_modules/.pnpm/[email protected]/node_modules/typescript/lib/typescript.js:141070:19)
    at Object.getOrCreateSourceFileByPath [as getSourceFileByPath] (/Users/david/discourse/discourse/node_modules/.pnpm/[email protected]/node_modules/typescript/lib/typescript.js:149935:30)
    at tryReuseStructureFromOldProgram (/Users/david/discourse/discourse/node_modules/.pnpm/[email protected]/node_modules/typescript/lib/typescript.js:125467:59)
    at createProgram (/Users/david/discourse/discourse/node_modules/.pnpm/[email protected]/node_modules/typescript/lib/typescript.js:124867:23)
    at synchronizeHostDataWorker (/Users/david/discourse/discourse/node_modules/.pnpm/[email protected]/node_modules/typescript/lib/typescript.js:149871:15)

One this happened, a full restart of the VSCode extension host was required. ('restart glint server' wasn't enough)

We've since managed to get the stable version of Glint working on our codebase, so that's solved the immediate problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants