Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate {{glint-*}} directives #761

Open
machty opened this issue Sep 23, 2024 · 3 comments
Open

Reinstate {{glint-*}} directives #761

machty opened this issue Sep 23, 2024 · 3 comments

Comments

@machty
Copy link
Contributor

machty commented Sep 23, 2024

I/we need to reimplement {{glint-*}} directives (glint-ignore, glint-expect-error, glint-nocheck) for Glint 2. Currently these directives are treated as comments that are completely ignored.

They "fell out" of Glint 2 because the way they were previously being processed did not neatly fall into the VirtualCode paradigm. I don't yet have an idea as to how to reimplement these in Volar land, but Vue has similar directives so we can probably just copy their implementation approach.

@bartocc
Copy link

bartocc commented Nov 27, 2024

is there a workaround to use Glint V2 in a project with .gts files and {{! @glint-expect-error }} directives?

@NullVoxPopuli
Copy link
Contributor

Not other than finishing this task

@bartocc
Copy link

bartocc commented Nov 28, 2024

What would be a good starting point to try and fix that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants