-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Glint does resolve extends
in tsconfig.json
from external packages
#549
Comments
Clarification—I believe this works correctly for local paths, based on this code: glint/packages/core/src/config/loader.ts Line 79 in 3b0d3ab
If I'm understanding correctly, both from that repro and from our discussion in chat, the issue is specifically that it does not follow an |
Good catch. Yes, you're correct. It only seems to come up when actually extends a tsconfig from another package. |
extends
in tsconfig.json
extends
in tsconfig.json
from external packages
I think this is resolved, as all projects I'm aware of that use Glint extend from |
We have faced this issue. We have a vertical micro frontend architecture, so we share some configurations across multiple Ember projects. We have observed that the glint configuration does not resolve correctly when a a) Creates a PR to resolve tsconfig.json from a package (favored one) {
"extends": "./node_modules/@package1/tsconfig.json"
} c) Use the patch-package to patch glint to resolve tsconfig.json from a package |
When extending a tsconfig that includes a glint configuration , glint doesn't follow the
extends
and, therefore, does not recognize that any config is present.I've created a reproduction here: https://github.com/cafreeman/glint-extends-bug-repro
The text was updated successfully, but these errors were encountered: