Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show loading deployment state in deployment list #139

Open
ilyakooo0 opened this issue Oct 13, 2021 · 0 comments
Open

Show loading deployment state in deployment list #139

ilyakooo0 opened this issue Oct 13, 2021 · 0 comments
Labels
enhancement New feature or request frontend

Comments

@ilyakooo0
Copy link
Member

When you open the list of deployments, after they are downloaded, there is a split second when the header of the table is shown, but not the content.

We do have untilReady primitive. If we stick it in this function, then we can show a widget while the row is actually loading:

activeDeploymentWidget hReq clickedEv dDyn' = do

To do this we would probably need some "loading deployment row" widget designed (we don't have one right now). Just sticking a spinner in there doesn't seem good enough to me. Having a table of 15 spinners seems silly to me.


I wonder if it is possible to still show the general "loading" widget while the rows are being loaded. But to me, it is not obvious at all how to achieve this. We would somehow need to extract the "Reflex-related" layout computation out of where it is actually laid out.

The general "loading" widget is currently displayed here:

widgetHold_ loadingDeploymentsWidget $

@ilyakooo0 ilyakooo0 added enhancement New feature or request frontend labels Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend
Projects
None yet
Development

No branches or pull requests

1 participant