Multiple linters #20
Comments
msuriar
added a commit
to msuriar/missile-tid
that referenced
this issue
Dec 26, 2022
As per tylerni7#20. This removes all references to `pylint` in favour of relying on whatever opinionated standards which `black` has gone with. - Remove Github Actions Workflow - Remove pylint section in `pyproject.toml` - Update README section on contributing to be more generic. ("Make sure all configured github actions pass" rather than naming specific checks). I haven't touched `flake8` for now, since in theory it catches a bunch of stuff which `black` doesn't care about, but which generally keeps codebases clean (e.g. checking for unused variables, imports etc). My instinct is to leave flake8 in place, unless people very strongly feel otherwise.
|
Seems like flake8 is I think most of the functionality there can be done with |
msuriar
added a commit
to msuriar/missile-tid
that referenced
this issue
Dec 28, 2022
As per tylerni7#20. This removes all references to `pylint` in favour of relying on whatever opinionated standards which `black` has gone with. - Remove Github Actions Workflow - Remove pylint section in pyproject.toml - Update README section on contributing to be more generic. ("Make sure all configured github actions pass" rather than naming specific checks). I haven't touched `flake8` for now, since in theory it catches a bunch of stuff which black doesn't care about, but which generally keeps codebases clean (e.g. checking for unused variables, imports etc). My instinct is to leave flake8 in place, unless people very strongly feel otherwise.
Merged
tylerni7
pushed a commit
that referenced
this issue
Dec 28, 2022
As per #20. This removes all references to `pylint` in favour of relying on whatever opinionated standards which `black` has gone with. - Remove Github Actions Workflow - Remove pylint section in pyproject.toml - Update README section on contributing to be more generic. ("Make sure all configured github actions pass" rather than naming specific checks). I haven't touched `flake8` for now, since in theory it catches a bunch of stuff which black doesn't care about, but which generally keeps codebases clean (e.g. checking for unused variables, imports etc). My instinct is to leave flake8 in place, unless people very strongly feel otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Seems like there are multiple Github workflow files which check the code for various formatting (flake8, pylint, and black). Since black is the most strict, why not just run that one? Consolidating would simplify contribution guidelines, save on build minutes, especially if using free actions and scope of tests increases in future.
There are also some conflicts in each of the settings files (.flake8, pyproject.toml) regarding line length and ignored exceptions. Moving completely to black will probably fix these, as it's generally without configuration.
The text was updated successfully, but these errors were encountered: