feat(math): Replace math library - malachite -> dashu #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewWestberg
force-pushed
the
amw/crypto-math
branch
from
40027a4
to
b729871
Compare
AndrewWestberg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Malachite has a bad license for our open-source project.
mhogrefe/malachite#52 (comment)
This replaces our bigint implementation with dashu that has a nicer license. It's not quite as fast, but it will work for now. The fastest would be gmp or Rug based on gmp, but that relies on native code that doesn't compile on windows.
We need to ensure we maintain windows compatibility for the Amaru project and the possibility of full-node wallets.