From d6a7069d76bc83083aebb5049c07b87111b216ec Mon Sep 17 00:00:00 2001
From: Daniel Schobel <dschobel@twitter.com>
Date: Mon, 6 Aug 2018 21:22:26 +0000
Subject: [PATCH] Twitter-oss: Prepare OSS libraries for release 18.8

Problem

We want to release the next versions of our Twitter OSS libraries 18.8
 - util
 - scrooge
 - finagle
 - twitter-server
 - finatra

Solution

Prepare libraries for their next releases.

JIRA Issues: CSL-6773

Differential Revision: https://phabricator.twitter.biz/D199004
---
 CHANGES                          |  3 +++
 README.md                        |  2 +-
 build.sbt                        |  2 +-
 demos/scrooge-maven-demo/pom.xml | 12 ++++++------
 scrooge-maven-plugin/pom.xml     |  4 ++--
 5 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/CHANGES b/CHANGES
index a4a6e68c5..1139abe71 100644
--- a/CHANGES
+++ b/CHANGES
@@ -4,6 +4,9 @@
 
 Unreleased
 ----------
+
+18.8.0
+-------
  - scrooge-core: Add interface for Scala generated Enum objects. ``PHAB_ID=D197147``
  - scrooge-core: Trait `c.t.scrooge.ThriftService` is now `c.t.finagle.thrift.ThriftServiceMarker`.
    Scrooge generated service objects now all inherit from `c.t.finagle.thrift.ThriftService`. Also,
diff --git a/README.md b/README.md
index 995f80d10..7af8e2888 100644
--- a/README.md
+++ b/README.md
@@ -1,6 +1,6 @@
 # Scrooge
 
-[![Build status](https://travis-ci.org/twitter/scrooge.svg?branch=develop)](https://travis-ci.org/twitter/scrooge)
+[![Build status](https://travis-ci.org/twitter/scrooge.svg?branch=master)](https://travis-ci.org/twitter/scrooge)
 [![Codecov](https://codecov.io/gh/twitter/scrooge/branch/develop/graph/badge.svg)](https://codecov.io/gh/twitter/scrooge)
 [![Project status](https://img.shields.io/badge/status-active-brightgreen.svg)](#status)
 [![Gitter](https://badges.gitter.im/twitter/finagle.svg)](https://gitter.im/twitter/finagle?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge)
diff --git a/build.sbt b/build.sbt
index a7ebd674a..530c20472 100644
--- a/build.sbt
+++ b/build.sbt
@@ -5,7 +5,7 @@ import scoverage.ScoverageKeys
 // 'git checkout develop; sbt publishLocal' to publish SNAPSHOT versions of these projects.
 
 // All Twitter library releases are date versioned as YY.MM.patch
-val releaseVersion = "18.8.0-SNAPSHOT"
+val releaseVersion = "18.8.0"
 
 val libthriftVersion = "0.10.0"
 
diff --git a/demos/scrooge-maven-demo/pom.xml b/demos/scrooge-maven-demo/pom.xml
index dcde41ad1..45e63b031 100644
--- a/demos/scrooge-maven-demo/pom.xml
+++ b/demos/scrooge-maven-demo/pom.xml
@@ -33,27 +33,27 @@
     <dependency>
       <groupId>com.twitter</groupId>
       <artifactId>util-core_2.12</artifactId>
-      <version>18.8.0-SNAPSHOT</version>
+      <version>18.8.0</version>
     </dependency>
     <dependency>
       <groupId>com.twitter</groupId>
       <artifactId>util-codec_2.12</artifactId>
-      <version>18.8.0-SNAPSHOT</version>
+      <version>18.8.0</version>
     </dependency>
     <dependency>
       <groupId>com.twitter</groupId>
       <artifactId>finagle-core_2.12</artifactId>
-      <version>18.8.0-SNAPSHOT</version>
+      <version>18.8.0</version>
     </dependency>
     <dependency>
       <groupId>com.twitter</groupId>
       <artifactId>finagle-thrift_2.12</artifactId>
-      <version>18.8.0-SNAPSHOT</version>
+      <version>18.8.0</version>
     </dependency>
     <dependency>
       <groupId>com.twitter</groupId>
       <artifactId>scrooge-core_2.12</artifactId>
-      <version>18.8.0-SNAPSHOT</version>
+      <version>18.8.0</version>
     </dependency>
     <dependency>
       <groupId>junit</groupId>
@@ -132,7 +132,7 @@
       <plugin>
         <groupId>com.twitter</groupId>
         <artifactId>scrooge-maven-plugin</artifactId>
-        <version>18.8.0-SNAPSHOT</version>
+        <version>18.8.0</version>
         <configuration>
           <thriftNamespaceMappings>
             <thriftNamespaceMapping>
diff --git a/scrooge-maven-plugin/pom.xml b/scrooge-maven-plugin/pom.xml
index fb8db7b95..aad72f9c0 100644
--- a/scrooge-maven-plugin/pom.xml
+++ b/scrooge-maven-plugin/pom.xml
@@ -5,7 +5,7 @@
   <artifactId>scrooge-maven-plugin</artifactId>
   <packaging>maven-plugin</packaging>
   <name>scrooge-maven-plugin</name>
-  <version>18.8.0-SNAPSHOT</version>
+  <version>18.8.0</version>
   <prerequisites>
     <maven>3.0.4</maven>
   </prerequisites>
@@ -247,7 +247,7 @@
     <dependency>
       <groupId>com.twitter</groupId>
       <artifactId>scrooge-generator_2.10</artifactId>
-      <version>18.8.0-SNAPSHOT</version>
+      <version>18.8.0</version>
     </dependency>
     <!-- Test Dependencies-->
     <dependency>