-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More benchmarks for creating bloom filters #672
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #672 +/- ##
===========================================
+ Coverage 89.45% 89.52% +0.06%
===========================================
Files 113 113
Lines 8944 8944
Branches 490 490
===========================================
+ Hits 8001 8007 +6
+ Misses 943 937 -6
Continue to review full report at Codecov.
|
by the way, I'm happy to merge this, but you never signed the CLA. Could you do that? |
Hello, I am extremely sorry I missed the CLA 🤦, I initially thought I already did it. |
Yeah I think we add a similar case before where the status got stuck in the Pending phase ... couldn't find the PR where that happened though |
In some use cases in Scio we create large Bloom filters with around 5 ~ 50M entries in some batch data pipelines. We were using BloomFilterAggregator API for most of our uses cases, and it felt like a good idea to bench mark the aggregator for comparison.