bug: ruby to use url instead of mount_name for mapping #622
Conversation
manisha1997
changed the title
| return input; | ||
| } | ||
|
|
||
| Pattern pattern = Pattern.compile("\\{([a-z0-9_]+)\\}"); |
There was a problem hiding this comment.
If this is a direct toCamelCase conversion, can we use a library to do it? example
If its not what format does it return ?
There was a problem hiding this comment.
This function takes input of format /v1/Services/{account_sid}/List to /v1/Services/{AccountSid}/List
The CaseUtils.toCamelCase() does not have this exact usecase fulfilled.
| @@ -222,7 +223,7 @@ private void updateContextResourceDependents(Map<String, String> dependentsForOp | |||
| if(listObjs != null) { | |||
| for (DirectoryStructureService.ContextResource cr : listObjs) { | |||
| String value = (dependentsForOperation.containsKey(cr.getFilename())) ? dependentsForOperation.get(cr.getFilename()) | |||
There was a problem hiding this comment.
Do we not need to change this line also? since we are modifying the mapOperationsDependents to always have resource_url as key?
There was a problem hiding this comment.
There are some use cases where dependentsForOperation.get(cr.getFileName()) has some data. How it is populated, will have to dig in further. So, as to not break the existing flow, I have kept it here.
There was a problem hiding this comment.
The values in dependentProperties would be of different formats like abc.json from file name and v1/something/abc via path, will that work fine? Can you add some testcases too? it'd be easier to understand the behaviour.
There was a problem hiding this comment.
yes, after this change, filename is no longer used to set mapping. Hence, removed it.
|
|
|
|
|
|
new validation check: https://buildkite.com/twilio/twilio-librarian-status-checks/builds/12123 |
Fixes
This implementation stops using mount_name and uses url to do the mapping
Validation check pipeline: https://buildkite.com/twilio/twilio-librarian-status-checks/builds/11963#_
Checklist
make test-dockerpython examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-goand inspect the diffmake testintwilio-gotwilio-goIf you have questions, please create a GitHub Issue in this repository.