Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whitespace changes for identical json #120

Open
liyifan5923013 opened this issue Nov 15, 2022 · 2 comments
Open

whitespace changes for identical json #120

liyifan5923013 opened this issue Nov 15, 2022 · 2 comments
Labels
type: twilio enhancement feature request on Twilio's roadmap

Comments

@liyifan5923013
Copy link

Issue Summary

hashicorp/terraform-plugin-framework#70

hashicorp/terraform-provider-aws#25340 (comment)

I’ve encountered an issue with terraform plan notify me when reading a json file that copy pasted from Twilio Console UI(The workflow configuration), that
~ resource "twilio_taskrouter_workspaces_workflows_v1" "voice_callback_workflow" {
~ configuration = jsonencode( # whitespace changes
I think it might be fixable by changing the twilio-provider using DiffSuppressFunc, to treat jsons with whitespaces the same. Do you think it make sense for twlio-provider to add that? or any other suggestions you have for this situation?

Steps to Reproduce

  1. copy paste a standard json file from Twilio UI for a Twilio Workflow.
  2. using jsondecode and jsonencode to put it as configuration for workflow
  3. terraform plan
  4. you can see that there are # whitespace changes

Code Snippet

# paste code here

Exception/Log

# paste exception/log here

Technical details:

  • terraform-provider-twilio version:
    0.18.9
  • terraform version:
    v0.15.3
@mattcole19
Copy link

This issue (DI-2437) has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.

@mattcole19 mattcole19 added the type: twilio enhancement feature request on Twilio's roadmap label Nov 18, 2022
@njsoria
Copy link

njsoria commented Jul 8, 2024

This would be helpful as it's adding a ton of noise to my teams' plans

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Development

No branches or pull requests

3 participants