Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(model): Implement user applications #2323

Merged
merged 9 commits into from
Oct 24, 2024
Merged

feat(model): Implement user applications #2323

merged 9 commits into from
Oct 24, 2024

Conversation

Erk-
Copy link
Member

@Erk- Erk- commented Mar 18, 2024

This pr implements the newly added user applications, this have had some testing done, but is still missing quite a bit of documentation and maybe a bit of bike-shedding about type names and/or layout.

@github-actions github-actions bot added c-cache Affects the cache crate c-http Affects the http crate c-model Affects the model crate c-standby Affects the standby crate c-util Affects the util crate c-validate Affects the validate crate t-feature Addition of a new feature labels Mar 18, 2024
laralove143
laralove143 requested changes Mar 21, 2024
View reviewed changes
Copy link
Member

@laralove143 laralove143 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there were too many

nit: these should be sorted alphabetically

comments so i stopped repeating them on every instance, besides that there are just things to discuss

twilight-http/src/request/application/command/mod.rs Outdated Show resolved Hide resolved
twilight-model/src/application/command/mod.rs Outdated Show resolved Hide resolved
twilight-model/src/application/interaction/mod.rs Outdated Show resolved Hide resolved
twilight-model/src/application/interaction/mod.rs Show resolved Hide resolved
twilight-model/src/application/interaction/mod.rs Outdated Show resolved Hide resolved
twilight-model/src/application/interaction/resolved.rs Outdated Show resolved Hide resolved
twilight-model/src/application/interaction/metadata.rs Show resolved Hide resolved
twilight-model/src/application/interaction/metadata.rs Outdated Show resolved Hide resolved
@Erk- Erk- marked this pull request as ready for review August 5, 2024 15:49
@Erk-
Copy link
Member Author

Erk- commented Aug 5, 2024

I think this is ready for a wider review.

@Erk- Erk- merged commit 4fae289 into main Oct 24, 2024
9 checks passed
@Erk- Erk- deleted the erk/user-apps branch October 24, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laralove143 laralove143 laralove143 approved these changes

@suneettipirneni suneettipirneni suneettipirneni approved these changes

@AEnterprise AEnterprise AEnterprise approved these changes

Assignees
No one assigned
Labels
c-cache Affects the cache crate c-http Affects the http crate c-model Affects the model crate c-standby Affects the standby crate c-util Affects the util crate c-validate Affects the validate crate t-feature Addition of a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Erk- @AEnterprise @suneettipirneni @laralove143