feat(http, validate): validate modal titles #2142
Conversation
github-actions
bot
added
c-http
| twilight_validate::component::modal_title_length(modal_title).map_err(|e| Error { | ||
| kind: ErrorType::BuildingRequest, | ||
| source: Some(Box::new(e)), | ||
| })?; |
There was a problem hiding this comment.
I'm unsure if this is the way I should handle this. If not, please let me know the desired solution.
There was a problem hiding this comment.
We don't do validation in IntoFuture at the moment... current intuition and prior art is that this should go in CreateResponse::new (which is a breaking change). But the downside there, too, is that it's a breaking change. Both of these are problems we're aiming to solve for 0.16, so I don't have a good answer here at the moment. cc @7596ff
There was a problem hiding this comment.
this request already accepts invalid data, so this isn't even a complete fix. my reflex is to just punt to 0.16 because this comes under the whole "validate at the end" paradigm. we can at least leave the changes in the validate crate to save this pr, but i don't want to do anything to the request at the moment
suneettipirneni
changed the title
zeylahellyer
added
w-do-not-merge
Validates modal
titles withinInteractionResponseDatawhen sending a response.Closes #1622