Expose prepared statements #27
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvandinther
force-pushed
the
25-expose-prepared-statements
branch
from
2fa47f9 to
5401452
Compare
|
Wondering if I revert this to commit 5401452 The current implementation isn't ideal. However, need to solve the issue in 5401452 where getting the first row of a queried statement after it was reset returns a row with a null pointer which creates a column type array with an enum value of 0 which is invalid. Seems like there is some kind of cursor reset somewhere? |
tvandinther
force-pushed
the
25-expose-prepared-statements
branch
from
fb175d7 to
85e5e7b
Compare
|
Waiting for fix to C bindings to be merged upstream tursodatabase/libsql#1713 |
|
Upstream fix has been merged. This branch requires an update to the revision of libsql being built to include it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25
This MR implements an interface to expose prepared statements. The internals are also changed to support this new feature.
Public interface changes are present in this MR.
Parameter binding implementation
Bound parameters are held internally in C# and are bound late when the statement is sent for execution. Resetting the statement currently creates a new prepared statement. A change to the bindings code needs to be made to make this both performant and to prevent new bindings from being made.