Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fr translation #260

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

victormltc
Copy link

  • added french language translation file
  • language button now cycles through languages instead of switching : EN > DE > FR > EN...

@freechelmi
Copy link

Hi , Are you planning on accept this PR ? I'm updating the french translation on my fork

@fcayre
Copy link

fcayre commented Feb 6, 2024

Any news on this? Its quite a trivial PR and useful for many.

@tuxedoder
Copy link
Contributor

tuxedoder commented Mar 28, 2024

I do appreciate the effort to translate it into french, but since the tcc devs can't speak french, support from our side is a bit hard. I won't be able to add, modify or proofread text myself.

Its quite a trivial PR

It would mean that we aren't able to publish a release easily, otherwise it would be missing translations every time text gets added or modified. One idea would be to push a release to Github and give some time for a translation pr before tag/deb release.

I'm updating the french translation on my fork

If there will be active translation support it would be possible to try. I couldn't find your fork @freechelmi. The current pr would need to get updated to the latest tcc version. I will try to get it merged if there is enough support to get text translated. One concern is if translations are missing or people stop translating, in that case the solution might be english text for missing parts or removal of the language. I would like to avoid using automatic translations from services like google or deepl that may sound wrong.

@fcayre
Copy link

fcayre commented Apr 2, 2024

@tuxedoder I forked TCC for Commown's usage as you broke (by accident, no offense intended) the compatibility of TCC with the NS50AU of Whyopencomputing which we distribute. My commits are there.

As you can see we regarding i18n:

  1. I had to adapt the textual content of TCC so that for instance our users do not overflow Tuxedo's support 😃
  2. I made the fr t10n effort of our version, so with our (slightly) modifier textual content

It would be nice if we could join our efforts to yours instead of forking, starting with trivial patches like fr t10n but maybe more in depth contributions in the longer term.

To start with i18n, the first thing would be to improve tooling, as we need automatic existing t10n messages merge during or after the messages' extraction. This way t10n contributions will be far easier. Have you given https://github.com/daniel-sc/ng-extract-i18n-merge a try? I haven't yet but can work on it if you think such a work could be merged in your codebase. Tell me what you think.

@tuxedoder
Copy link
Contributor

It would be nice if we could join our efforts to yours instead of forking, starting with trivial patches like fr t10n but maybe more in depth contributions in the longer term.

As a developer, help is appreciated, but what I can do will depend on management. I can ask if there are more specific requests, but I don't think tcc improvements will be denied.

I made the fr t10n effort of our version

I don't know what t10n refers to and can't find information for it.

To start with i18n, the first thing would be to improve tooling, as we need automatic existing t10n messages merge during or after the messages' extraction.

I used xliff-simple-merge to merge translation files and add new messages into different languages. I don't know if I ever tried ng-extract-i18n-merge.

npm run gen-lang
npx xliff-simple-merge -i "/home/code/tuxedo-control-center/src/ng-app/assets/locale/lang.xlf" -d '/home/code/tuxedo-control-center/src/ng-app/assets/locale/lang.fr.xlf' -o "/home/code/tuxedo-control-center/src/ng-app/assets/locale/lang.fr.xlf"

That example generates new messages based on source code and tags id with the i18n labels, puts them into lang.xlf and moves new messages into lang.fr.xlf, the french translation file now has new text with english placeholders which can be translated.

<p i18n="@@new_add">
    test message
</p>

lang.xlf
<trans-unit id="new_add" datatype="html">
  <source> test message </source>

lang.fr.xlf
<trans-unit id="new_add" datatype="html">
  <source> test message </source>
  <target state="new"> test message </target>

I am not entirely sure if my answer answers the question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants