-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to change the CPU governor #22
Comments
ATM the are fixed to default |
Correct, as discovered this is currently not configurable and is currently not planned. To keep the CPU frequency scaling "more ready" it's possible to choose only high frequencies in TCC. For most CPUs this will be kept to even though the governor is called powersave. Should you discover that the governor choice has a severe impact on something specific, please keep me posted. |
I often found the CPU frequency below the rated/setup minimum, especially during CPU intensive tasks. I can tell you, that's not what one wants. Anyway an option to setup the |
On my machine it freezes the mouse for a second. I changed the governor in the config files and patched the daemon, for now is working as expected. |
Hi @TheAifam5 I'm interested in how your patch looks like? 😄 |
I do not take any responsibility!@nickma82 as default, every profile has diff --git a/src/service-app/classes/CpuWorker.ts b/src/service-app/classes/CpuWorker.ts
index ee74d26..4302cc6 100644
--- a/src/service-app/classes/CpuWorker.ts
+++ b/src/service-app/classes/CpuWorker.ts
@@ -100,7 +100,8 @@ export class CpuWorker extends DaemonWorker {
this.setCpuDefaultConfig();
// Note: Hard set governor to default (not included in profiles atm)
- profile.cpu.governor = this.findDefaultGovernor();
+ if (!profile.cpu.governor)
+ profile.cpu.governor = this.findDefaultGovernor();
this.cpuCtrl.setGovernor(profile.cpu.governor);
this.cpuCtrl.setEnergyPerformancePreference(profile.cpu.energyPerformancePreference);
@@ -140,7 +141,8 @@ export class CpuWorker extends DaemonWorker {
const profile = this.tccd.getCurrentProfile();
// Note: Hard set governor to default (not included in profiles atm)
- profile.cpu.governor = this.findDefaultGovernor();
+ if (!profile.cpu.governor)
+ profile.cpu.governor = this.findDefaultGovernor();
let cpuFreqValidConfig = true;
|
This one is a must have IMHO along with #44 |
Little late to the party but since v1.0.9 governor "Full governor control" is still not reintroduced. Future update will include disabling the TCC cpu control however enabling possibility of using another tool in combination. Closing this for now as it should address the original issue. Feel free to reopen if not. |
I use two seperate profiles for AC or battery.
On battery, the default governor "powersave" is a fitting description.
When using AC profile, I do have my higher CPU clocks, but the governor is still "powersave". The governor "performance" might be more fitting.
The tool
paramano
fetches possible CPU governors and creates a list to choose from (e.g. AMD CPUs have other govenor names than Intel CPUs).How about adding a setting for a profile on which CPU governor has to be set?
I think this might improve behaviour of other applications, which might reduce/increase features depending on the CPU governor.
The text was updated successfully, but these errors were encountered: