Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal Storages: Renaming a storage doesnt change its name on already used storages #280

Closed
ValentinFutterer opened this issue Nov 11, 2024 · 1 comment · Fixed by tuwien-csd/damap-frontend#364, #324 or tuwien-csd/damap-frontend#417
Labels
bug Something isn't working

Comments

@ValentinFutterer
Copy link
Collaborator

Describe the bug
When creating a storage and renaming it, a revsion entity is created by envers. When a storage is assigned to a dataset, it is assigned to the most current revision entity. When the internal storage is changed, e.g. title, the dataset still points to the old revsion, so it keeps the old title, url, etc..

db screenshot:
image

frontend:
image

Is this a regression?
No.

Steps to Reproduce
Create an internal storage and go to step 5. Add a dataset to this storage. Then change the title of the storage in the admin UI. Go back to step 5 and notice that the title hasnt changed.

Expected behavior
The dataset should automatically be assigned to the latest storage revision entity.

Environment

  • Damap version 4.2.0
@ValentinFutterer
Copy link
Collaborator Author

PR only disabled the offending functionality, but did not resolve the bug, therefore the issue was reopened. Was erroniously closed while merging the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment