Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Install / Unpack selector #53

Open
1 task done
TheByKotik opened this issue Mar 28, 2022 · 2 comments
Open
1 task done

[Feature Request] Install / Unpack selector #53

TheByKotik opened this issue Mar 28, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@TheByKotik
Copy link

Is your feature request related to a problem? Please describe.
I have 3+ unpacked JRE and will be great have feature to update it.
image

I'm sure that it's not a 'known-not-a-bug'

  • Yes

Describe the solution you'd like
Keep unpacked JRE up-to-date.

Describe alternatives you've considered
None? Manual unpacking?

Additional request
Also support of minification (removing all files that not required to launch like docs).

@tushev
Copy link
Owner

tushev commented Mar 28, 2022

Hello, thank you for your report.

From your screenshot, I see that all the JREs are shown as Not detected. This usually happens if Update Watcher is unable to determine the version of the runtime, either from Windows Registry (MSIs) or release file (both MSIs and unpacked ZIPs).

In order for Update Watcher to work, release file MUST be present in the root directory that is specified in Updater's list (D:\Games\Minecraft\MultiMC\jre\17\s in one of your cases):
image

Once you have your installations look like this in the list:
image
(pay attention to User added status and presence of detected version + vendor), you can check for updates:

image

With the current version of Update Watcher, you should use context menu in order to manually download ZIPs.
You also have to unpack them manually, and keep the list of installation directories up-to-date.

Full automation is currently supported for MSI packages only.
I may include automation for ZIPs in one of the upcoming releases.


As for your Additional request: it's a rare feature that is not used by many folks.
I would prefer not to implement it myself, but rather to use one of the existing minifiers like https://github.com/abrayall/hummingbird (or the user could write the script themselves).

There's a Post-Install command feature in Update Watcher > Settings, please check it:
image

It is executed after MSI installation, I cannot say whether it will work after using context menu ZIP commands (let me know).

@tushev tushev added the enhancement New feature or request label Mar 28, 2022
@TheByKotik
Copy link
Author

In order for Update Watcher to work, release file MUST be present in the root directory that is specified in Updater's list

Thanks, I didn't read your code and i have been sure you using checks like this one:
https://github.com/MultiMC/Launcher/blob/develop/libraries/javacheck/JavaCheck.java
https://github.com/MultiMC/Launcher/blob/develop/launcher/java/JavaChecker.cpp

As for your Additional request: it's a rare feature that is not used by many folks.
I would prefer not to implement it myself, but rather to use one of the existing minifiers like https://github.com/abrayall/hummingbird (or the user could write the script themselves).

I mean just do not unpack:
include dir.
legal dir.
release file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants