Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom thresholds #49

Open
tushartushar opened this issue Apr 12, 2018 · 1 comment
Open

Custom thresholds #49

tushartushar opened this issue Apr 12, 2018 · 1 comment

Comments

@tushartushar
Copy link
Owner

  • Are we actually using 'ThresholdsParser'? I only see it is being used from tests!
  • Also, we need to change the location of the threshold.txt and make sure that it is present in the target folder.
  • Another thing is that if we don't find the file, we need to return the standard thresholds (and not throw an exception)
@Thodoras
Copy link
Collaborator

The functionality is implemented but I didn't add it in the main flow.
And yes adding it to the main flow someone would have to consider
to try to parse to and otherwise (maybe catch the exception?) use the default
attributes of the threshold class which is also already implemented.

I totally agree with the second bullet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants