Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add translate (#6) and fix alignment (#7) #10

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

tusharnankani
Copy link
Owner

Closes #6
Fixes #7

Current behavior

swadesh.mp4

Side note:

  • I have made changes just to the index.html, and not the remaining files.
  • So, in the hackathon, I just copy-pasted the navbar and whatever files were required, were linked to the respective files.
  • So this is how the remaining pages look like:

image

  • Now, that we are finally making changes the right way, why not reuse the code. So I know how to include the navbar or header/footer.
  • For this, we can write something on these lines for using the navbar on multiple pages. Using jquery.
<!--Navigation bar-->
<div id="nav-placeholder">

</div>

<script>
$(function(){
  $("#nav-placeholder").load("nav.html");
});
</script>
<!--end of Navigation bar-->

Or create a separate .html file, but we will have to create a separate one for the farmer/wholesaler.

  • Also, I have commented on the code instead of removing it for now.

TODO:

  • Remove translation.js and other unused JS functions.
  • Remove unused CSS for the same.
  • Make changes to the navbar for the remaining pages as well.

@tusharnankani tusharnankani marked this pull request as draft June 13, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: misplaced components in the navbar add google translate dropdown
1 participant