Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add google translate dropdown #6

Open
tusharnankani opened this issue Dec 19, 2020 · 3 comments · May be fixed by #10
Open

add google translate dropdown #6

tusharnankani opened this issue Dec 19, 2020 · 3 comments · May be fixed by #10
Labels
enhancement New feature or request

Comments

@tusharnankani
Copy link
Owner

Add google translate dropdown for multiple languages instead of just Hindi, the page will translate to any language under Translate.

@tusharnankani tusharnankani added the enhancement New feature or request label Dec 19, 2020
@tusharnankani
Copy link
Owner Author

@HarshKapadia2 @KartikSoneji

image

I have made some changes and this is how the navbar looks like. It also fixes #7. I also removed the A+ and A- buttons.

PS: I would have made a PR for you to review but I had been working on the master branch, hence I am mentioning it here before pushing the changes.

We will also have to delete some functions and the translation files once these changes are implemented. Also, we might have to optimize the CSS files.

@KartikSoneji
Copy link
Collaborator

KartikSoneji commented Dec 24, 2020

@tusharnankani you can still make a PR, just run git switch -c <branch name>, then push the new branch.

Please make sure that the changes are self-contained, if you need to delete some files then include those changes in the PR.

Also, don't forget to update the screenshots in the readme.

@tusharnankani
Copy link
Owner Author

Thanks! @KartikSoneji

Also, don't forget to update the screenshots in the readme.

Yes, will be done once all the changes are implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants