Skip to content

app_persistency: new implementation #282

app_persistency: new implementation

app_persistency: new implementation #282

This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Actions / clippy failed Sep 7, 2023 in 0s

clippy

4 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 4
Warning 0
Note 0
Help 0

Versions

  • rustc 1.72.0 (5680fa18f 2023-08-23)
  • cargo 1.72.0 (103a7ff2e 2023-08-15)
  • clippy 0.1.72 (5680fa1 2023-08-23)

Annotations

Check failure on line 146 in tpi_rs/src/middleware/persistency/binary_persistency.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref

error: deref which would be done by auto-deref
   --> tpi_rs/src/middleware/persistency/binary_persistency.rs:146:13
    |
146 |             (*cache).1.as_ref().unwrap().send(Instant::now())?;
    |             ^^^^^^^^ help: try this: `cache`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

Check failure on line 143 in tpi_rs/src/middleware/persistency/binary_persistency.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref

error: deref which would be done by auto-deref
   --> tpi_rs/src/middleware/persistency/binary_persistency.rs:143:24
    |
143 |         let previous = (*cache).0.insert(default_hash(key), encoded.clone());
    |                        ^^^^^^^^ help: try this: `cache`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

Check failure on line 97 in tpi_rs/src/middleware/persistency/binary_persistency.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref

error: deref which would be done by auto-deref
  --> tpi_rs/src/middleware/persistency/binary_persistency.rs:97:40
   |
97 |         let data = bincode::serialize(&(*cache).0)?;
   |                                        ^^^^^^^^ help: try this: `cache`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
   = note: `-D clippy::explicit-auto-deref` implied by `-D warnings`

Check failure on line 43 in tpi_rs/src/middleware/persistency/binary_persistency.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

very complex type used. Consider factoring parts into `type` definitions

error: very complex type used. Consider factoring parts into `type` definitions
  --> tpi_rs/src/middleware/persistency/binary_persistency.rs:43:12
   |
43 |     cache: RwLock<(HashMap<u64, Vec<u8>>, Option<Sender<Instant>>)>,
   |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
   = note: `-D clippy::type-complexity` implied by `-D warnings`