[BUG] timesnap always closes the browser even on using remoteUrl, where a disconnect would make more sense

[cb109]

Describe the bug

Passing the remoteUrl option allows reusing a running Chrome instance for screenshots, but it will always close that browser at the end. Instead I would expect it to only close the tab it created, and just disconnect from the browser, so that the browser instance can be reused further.

To Reproduce

Please run this script (node chrome_server.js) in a shell with puppeteer installed to open a Chrome instance, the browserWSEndpoint URL will be printed to the terminal for you to copy-paste:

// chrome_server.js
const puppeteer = require('puppeteer');

(async () => {
    var browser = await puppeteer.launch({
      headless: false,
      executablePath: '/usr/bin/google-chrome',  // Adjust as needed or remove to use default Chrome binary.
    });
    var browserWSEndpoint = browser.wsEndpoint();
    console.log(browserWSEndpoint);

    browser.disconnect();
})();

Then in a separate shell run timesnap against that remoteUrl like:

timesnap --remote-url <browserWSEndpoint> ...

Expected behavior

It should open a new tab in the running Chrome, do its thing, then close the tab but leave the browser opened/alive.

• When remoteUrl is passed, the entry script already decides between using puppeteer.launch() VS puppeteer.connect():
  https://github.com/tungs/timesnap/blob/main/index.js#L115-L117
• It should do the same at the end, deciding between browser.close() and browser.disconnect(): https://github.com/tungs/timesnap/blob/main/index.js#L284

Attachments and Screenshots

Browser is closed at the end of the timesnap call:

Desktop (please complete the following information):

• OS: Ubuntu LTS 20.04
• Node Version: v16.20.2
• Timesnap Version 0.3.3

A so far simple PR: #81
Please let me know what you think, thanks.