-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle chrome's pretty print button #341
Conversation
Now I see that the second version of the code breaks some pages. It removed the first div from any page opened 😂 |
@bukowskiadam, It definitely would be good to update the sass version at some point to get rid of that crusty old node-gyp dependency that caused so many years of pain. |
Thanks for the PR. Im planning to address the issue this weekend |
@bukowskiadam would it be possible to retrieve the 'pre' node using a for loop? just in case there are more elements in the future. |
@chinhoe I think there is more to improve in the code. Now, with my fixed code, I get two scrollbars like this 👇🏻 Looping over elements might break some pages as I did blindly removing the first element if it's not a PRE. Every direct child ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
we understand again in these few days that the plugin is very useful 😄 when will the pr be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request doesn't seem relevant anymore. The extension is working again in the last version of Chrome.
True story, closing. I confirm that the newest stable chrome is back to normal because they got rid of the checkbox. Thank you all for the attention! |
I think the Pretty Print checkbox is back in the latest Chrome update? |
Trying to fix #340
I tested it locally, and it works.
A way to build that worked for me:
fnm use 10
ornvm use 10
npm i
and ignore node-gyp errorsnpm run release
(builds minified files) and load unpacked like stated in the readme file