-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency installation enhancement #512
Comments
@MatthijsBurgh @Timple need your thoughts on this. As this is the biggest issue when moving to python and extending support for OS other than Ubuntu. |
Current situation is basically declaring dependencies for it's script (albeit Regarding extending support for anything other than Ubuntu: why? This creates a lot of maintenance work. There is a reason even ROS until recently only supported ubuntu officially. |
There won't be any change in the execution logic if we use the second option. But it will simplify the target creation process largely. With the first option, the execution becomes as you mentioned. I'm not suggesting that we support any other OS other than Ubuntu at the moment. But at Avular I'm first moving melodic packages to noetic and eventually to ROS2. For ROS2 I want to try having this toolkit and extending it to other OS using a plugin based system like colcon does, instead of writing something new. So with a bit of refactor here that should be possible. |
Ah, alright. I'm game! |
In the meantime at another company not that far away... We've solved the issue by supporting |
@Timple Yeah definitely :) I recently added Docker-in-Docker support for GitLab CI with private repositories, private docker registries and CI config inheritance. Want me to backport that? 😆 |
That does sound really interesting! |
What about the CI? BitBucket itself or something else? |
Bitbucket pipelines |
I think this is (partly) fixed by #524 |
Problem
Our current system first uses a
install.yaml
and then ainstall.bash
to install a target. With this some targets that are needed as a immediate dependency in install.bash are either installed using thetue-install-x-now
commands or bypassed totally by using commands likesudo apt-get install ...
.The reason being we collect all package manager based targets in a list to be installed at the end of the execution. This was done to avoid installation at every parse of
install.yaml
and has made a mess in dependency installation with tons oftue-install-now
commands.We need something in between the two approaches.
Possible solutions:
install.yaml
andinstall.bash
are detected for a target, then flush the current list of targets to be installed at the end by installing them at that instant.install.yaml
andinstall.bash
are present and rest at the end of the execution.Expected result
tue-install-x-now
commandsinstall.yaml
onlyinstall.bash
with no dependency installations commandsThe text was updated successfully, but these errors were encountered: