Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code style enforcing #69

Open
wants to merge 168 commits into
base: master
Choose a base branch
from
Open

Code style enforcing #69

wants to merge 168 commits into from

Conversation

marenz2569
Copy link
Collaborator

@marenz2569 marenz2569 commented Sep 24, 2024 •
edited
Loading

This PR creates clang-tidy rules, a CI action to enforce them, adds doc-strings and refactors FIRESTARTER to aid the clang-tidy rules. All changes should be non functional.
Follow up tickets were created: #71, #72, #73, #74, #75, #76, #77, #78, #81, #82, #83, #84, #85, #86, #87 and #90.

@marenz2569
enable compile commands generation
f67729b
@marenz2569
add .clang-format file base on LLVM style
f24a0b2
@marenz2569
clang-format
9732bdb
@marenz2569
ignore clang-format in blame
f4fd0ec
@marenz2569
add clang-format ci job
de5ffd6
@marenz2569
add .cache folder to gitignore
7473e5f
@marenz2569
add .clang-tidy
c513d31
@marenz2569
disable clang-tidy extension that causes crash
29df30a
@marenz2569
add clang-tidy workflow
f3960af
@marenz2569
Merge remote-tracking branch 'origin/master' into code-style-enforcing
742712e
@marenz2569
first pass of clang-tidy for the header files
b79754e
@marenz2569
update .clang-tidy
37a8518
@marenz2569
add an empty file as a workaround for clangd issue
90beb59
@marenz2569
second pass of clang-tidy for the header files. use unique_ptr for th…
ff6113b 
…e payload instead of raw pointers
@marenz2569
clang-tidy workflow: add .clang-tidy file location
c33291f
@marenz2569
clang-tidy workflow: update .clang-tidy file location
a3b01b1
@marenz2569
clang-tidy workflow: add comment and rum build before clang-tidy
d53a107
@marenz2569
clang-tidy workflow: update fetch depth
fafd720
@marenz2569
clang-tidy workflow: clone with submodules
6e4c880
@marenz2569
first pass of clang-tidy for the source files
770b405
@marenz2569
clang-tidy: allow big functions
1d98664
@marenz2569
use enum class for constants
5aa731a
@marenz2569
clang-tidy: disable checks in lib folder
334b872
@marenz2569
refactor cpp side memory management of the high-load function. remove…
6b388f6 
… lots of reinterpret_cast and pointer magic. refactor dump register code.
@marenz2569
fix divission by zero warning
3876411
@marenz2569
clang-tidy fixes. create struct for allocating whole cache lines. cle…
ba43956 
…an up memory management for the high-load routine.
@marenz2569
clang-tidy fixes
962c0da
@marenz2569
cleanup load worker thread
5e04c5d
@marenz2569
refactor load worker data
43fd6cb
@marenz2569
use std::chrono::microseconds instead of uint64_t
d608e98
@marenz2569
docstrings
23ccb55
@marenz2569
add docstrings
5a301a3
@marenz2569
add docstrings
e72b010
@marenz2569
change log error to log warn to not abort on failed metric init
ad22452
@marenz2569
add docstrings for measurement and metrics
7498853
@marenz2569
fix refactor in rapl metric
eef129f
@marenz2569
rapl metric docstrings
bbe6f57
@marenz2569
remove unused return argument in watchdogworker
283ec47
@marenz2569
add docstrings to OneAPI
dc6c80a
@marenz2569
doc strings and rename funtions in optimization
cfc2cf1
@marenz2569
cleanup optimization worker. add docstrings
29168c2
@marenz2569
ci: remove GHC artifacts to make more space for the rocm build
1690ec0
@marenz2569
explicitly check if number of GPUs is not equal to 0.
dee9fc1
@marenz2569
update docstring in cuda and oneapi files
9c32916
@marenz2569
add docstring for config
08a3772
@marenz2569
fix offset in error detection algorithm. add docstrings
0de3fa6
@marenz2569
docstring for DumpRegisterWorkerData
427675a
@marenz2569
add docstrings to Firestarter.hpp
e04716f
@marenz2569 marenz2569 marked this pull request as ready for review November 8, 2024 16:37
@marenz2569
Copy link
Collaborator Author

marenz2569 commented Nov 8, 2024 •
edited
Loading

Open Points:

  • Test functionality of FIRESTARTER:
    • Measurement
    • Optimization
    • Watchdog
    • CUDA
    • HIP
    • OneAPI
    • Error detection
    • Dump registers
  • make sure the include style is consistent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschoene rschoene Awaiting requested review from rschoene

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marenz2569