Changes assigned by moderator #88
Labels
documentation
Improvements or additions to documentation
enhancement
An existing feature can be enhanced/improved.
optimization
The algo/code can be optimized. A better approach
Prioritize
Extra attention is needed
.workspace-tabs .workspace-leaf .view-content {, .workspace-leaf-content .view-content {, .modal {, .modal-close-button {
Please don't overwrite core styling in a plugin, add another class/data attribute so it only applies to your plugin.
this.createLocalStorageAndScanModifiedFiles();
Because these two tasks are quite heavy in calculation, they should be run after the layout is ready.
Any blocking code that is inside the regular onload will block the UI from being shown.
.setViewState({ type: VIEW_TYPE_TASKBOARD, active: true });
Use the new ensureSideLeaf function.
id: "1",, id: "2",, id: "3",
The command id should give a indication what the command is used for.
this.registerEvent(
Remove these unused event listeners, they just add unecessary load.
this.registerDomEvent(closeButton, "mouseenter", () => {
Changes should be saved right after they have been made, there are many ways to quit Obsidian without triggering this.
const moment = require("moment");, const moment = require("moment");
Import it from the Obsidian package instead, and using the same syntax you import everything else.
1: "Save",
In the rest of the code I had no idea what string should be rendered, it should be possible to see just from the identifier what kind of message should be shown.
And for a lot of these english strings and many more strings found in the rest of the code: use sentence case in UI
placeholder="Hit Enter after typing", Add Column
There are also some strings in your code that haven't been translated yet.
58: "Global Settings",, 36: "Plugin Global Settings",, 37: "Settings",, contentEl.createEl("h1", {
Don't add a top-level heading in the settings tab, such as "General", "Settings", or the name of your plugin.,
Grouping similar setting using Tabs in settings tab #89
private static createFragmentWithHTML = (html: string) =>
use the existing sanitizeHTMLToDom function instead.
const cssStyles =
This should be in the styles.css file.
// Setting for Plugin Language
This should not be a setting, the plugin should always follow the language configured in Obsidian, if you don't have the translation for a particular language fallback to english.
const img = createEl("img", {, const img = createEl("img", {
This needs to be embedded in the plugin, not loaded externally.
console.log('Task deletion canceled');, console.log("Board Deletion Operation Cancelled.");
Please avoid unnecessary logging. If you need it for debugging purposes, add a check to only log during development.
The text was updated successfully, but these errors were encountered: