Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename/document hrpc.Families to indicate that you can specify column qualifiers #191

Open
tomasbanet opened this issue Jul 22, 2022 · 2 comments

Comments

@tomasbanet
Copy link

It is not immediately clear when creating a Scan request how one should specify the columns in a row that they are interested in retrieving.

After seeing some existing code written by others I saw that you can use the tsuna/gohbase/hrpc/query.go:Families option to specify the family as a key and the list of columns (qualifiers) in the family as a string slice in a map to get those families/columns in the result.

We should add some comments documenting what the Families map keys and values are supposed to represent. Alternatively rename the option to something like FamiliesWithColumns or FamiliesWithQualifiers to indicate that column selection is supported.

@dethi
Copy link
Collaborator

dethi commented Aug 16, 2022

Right, I think the best would be to add documentation. Don't really think the other two functions would make sense.
Wanna contribute and make the change? :)

@tomasbanet
Copy link
Author

Sure. I'll add it to the godoc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants