Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i've not good at result. #5

Open
SinDongHwan opened this issue May 13, 2019 · 4 comments
Open

i've not good at result. #5

SinDongHwan opened this issue May 13, 2019 · 4 comments

Comments

@SinDongHwan
Copy link

i've run code on jupyter-notebook step by step, and didn't edit codes.

when only generator model train, result is good.

however, when generator and discriminator model train, very bad.TT

After Generator&Discriminator train, Generator model evaluates.
After Generator&Discriminator train, Generator model evaluates.

How train model, i can get good result.

Thank you^^

@SinDongHwan SinDongHwan changed the title i've good at result. i've not good at result. May 13, 2019
@tsujuifu
Copy link
Owner

tsujuifu commented May 13, 2019

Hi, SinDongHwan, thanks for following my work.
To train the generator with the discrminator, you should train with both seq2seq loss and policy gradient (RL) loss.
If you only train with RL loss, the generator will easily fall into a terrible local minimum so that you can see the generator only outputs duplicate frame IDs.

@SinDongHwan
Copy link
Author

SinDongHwan commented May 14, 2019

Thank you for kind answer.^^
I'm interested in the Video Summarization using Deep Learning.

Could I some questions? Is different your other statement and the following statement?

In a "model_vsum-ptr-gan.ipynb", only the generator trains with seq2seq loss first.
And then, the generator with the discriminator trains using policy gradient(RL) loss.

the attached above picture is result in a "model_vsum-ptr_gan.ipynb" final generator model with discriminator.

@dashuzhilin
Copy link

But when I set is_tr=True, is_pg=True, the results is not good...Is there anything wrong with this?
image

@SinDongHwan
Copy link
Author

@dashuzhilin
i've gotten same result.
i don't know... so i couldn't solve...
i'm waiting writer...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants