Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngx-confetti error type. #94

Open
sebalr opened this issue Mar 4, 2024 · 4 comments
Open

ngx-confetti error type. #94

sebalr opened this issue Mar 4, 2024 · 4 comments

Comments

@sebalr
Copy link

sebalr commented Mar 4, 2024

Details

ngx-confetti is not working in Angular 15 project using npm.

Error: node_modules/ng-particles/lib/ng-particles.component.d.ts:18:89 - error TS2344: Type '{ options: { alias: "options"; required: false; }; url: { alias: "url"; required: false; }; id: { alias: "id"; required: false; }; particlesInit: { alias: "particlesInit"; required: false; }; }' does not satisfy the constraint '{ [key: string]: string; }'. Property '"options"' is incompatible with index signature. Type '{ alias: "options"; required: false; }' is not assignable to type 'string'. 18 static ɵcmp: i0.ɵɵComponentDeclaration<NgParticlesComponent, "ng-particles", never, { "options": { "alias": "options"; "required": false; }; "url": { "alias": "url"; "required": false; }; "id": { "alias": "id"; "required": false; }; "particlesInit": { "alias": "particlesInit"; "required": false; }; }, { "particlesLoaded": "particlesLoaded"; }, never, never, false, never>;

@sebalr sebalr added the sweep Assigns Sweep to an issue or pull request. label Mar 4, 2024
@tsparticles tsparticles deleted a comment from sweep-ai bot Mar 5, 2024
@matteobruni matteobruni removed the sweep Assigns Sweep to an issue or pull request. label Mar 5, 2024
@tsparticles tsparticles deleted a comment from sweep-ai bot Mar 5, 2024
@matteobruni
Copy link
Contributor

Please describe a bit what is the problem with some code samples, and please don't trigger sweep on your own.

@sebalr
Copy link
Author

sebalr commented Mar 5, 2024

Sorry about sweep, I didn't know that it was optional.
Theres is an error in node_modules folder in ngx-particles component input declaration. No code sample is needed, just plain Angular 15 projects fails to build with this library installed.
I did some research and it looks like that the library is incompatible with Angular 15, I tried with 17 and works.
A note on readme with required version would be nice.
Thanks

@matteobruni
Copy link
Contributor

This is something with angular build, something built with newer angular version is not compatible backwards.

@sebalr
Copy link
Author

sebalr commented Mar 5, 2024

Got it, thanks. It would be nice to have a min compatible version note on readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants