Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract KTE to separate Module #19

Merged
merged 7 commits into from
Mar 17, 2024
Merged

Conversation

MariusSp
Copy link
Contributor

@MariusSp MariusSp commented Mar 16, 2024

Disclaimer: I dont have gradle experience... Just trying to apply my maven knowledge.

  • extract KTE to separate module (JTE flavor pulls in kotlin-compiler-embeddable #18)
    • inherits from jte module.
    • Sets template-suffix to .kte
  • update jte from 3.1.0 to 3.1.9
  • core: use jte-kotlin for compilation only (might need to re-add it in KTE module for at-runtime stuff, whatever that might be)
  • bump version to 0.7.3-SNAPSHOT

Only tested the jte dependency. Resulting jar does not contain the kotlin-compiler-embeddable anymore.

@MariusSp MariusSp marked this pull request as draft March 16, 2024 18:37
@tschuehly
Copy link
Owner

I've fixed the kotlin dependency and added a gradle project for easier testing.
The tests were all green for me

@tschuehly
Copy link
Owner

tschuehly commented Mar 16, 2024

Tests run successfully, only the installation docs need to be updated!

@tschuehly tschuehly marked this pull request as ready for review March 17, 2024 08:50
@tschuehly tschuehly self-requested a review March 17, 2024 15:32
@tschuehly tschuehly merged commit 672b911 into tschuehly:master Mar 17, 2024
7 checks passed
@tschuehly
Copy link
Owner

@MariusSp
Thank you very much for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants