Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DropdownField missing error styling #55

Open
brandonlenz opened this issue Apr 18, 2023 · 6 comments
Open

DropdownField missing error styling #55

brandonlenz opened this issue Apr 18, 2023 · 6 comments

Comments

@brandonlenz
Copy link
Contributor

As a claimant I want the error outline styling to apply to dropdown fields:

image
@brandonlenz
Copy link
Contributor Author

In previous work we've done this "bug" exists. Passing the usa-input--error class "fixes" it, would want a designer to confirm which they'd rather see:

Currently:
image

"Fixed":
image

@brandonlenz
Copy link
Contributor Author

If desired to be fixed, this should be a change to reactUSWDS adding a validationStatus prop to the Dropdown component

@brandonlenz
Copy link
Contributor Author

@werdnanoslen what are your thoughts on this?

@werdnanoslen
Copy link

agreed, and yeah definitely a reactUSWDS issue

@brandonlenz brandonlenz mentioned this issue Apr 27, 2023
Closed
@brandonlenz
Copy link
Contributor Author

Fixing in ReactUSWDS here

@brandonlenz
Copy link
Contributor Author

Moved to blocked until the ReactUSWDS PR is reviewed, merged, and released so that we can use it here 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@werdnanoslen @brandonlenz