Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG]: Update jsdom/nwsapi when bugfix available #123

Open
kleinschmidtj opened this issue May 24, 2023 · 0 comments
Open

🐛 [BUG]: Update jsdom/nwsapi when bugfix available #123

kleinschmidtj opened this issue May 24, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@kleinschmidtj
Copy link
Contributor

Current Behavior

Currently our package json has a resolution for an earlier version of [nwsapi](https://github.com/dperini/nwsapi)

We need this currently so that the identity test to open the modal works.

The bug looks like this when we use v2.2.4 (latest version) of nwsapi (dependency of jsdom):

Screenshot 2023-05-24 at 11 37 22 AM

Expected Behavior

We should not need this resolution once there is a bugfix released. (new version of nwsapi that fixes the issue.)

We should not see the modal test fail.

Steps To Reproduce

  1. Remove resolution in package json
  2. Run yarn test identity
  3. See error.

Environment

Jest, jsdom

Anything else?

@kleinschmidtj kleinschmidtj added the bug Something isn't working label May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant