Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change chord separator #83

Open
truj opened this issue Nov 28, 2023 · 1 comment
Open

change chord separator #83

truj opened this issue Nov 28, 2023 · 1 comment
Assignees
Labels
midicapl For changes in the MidicaPL language

Comments

@truj
Copy link
Owner

truj commented Nov 28, 2023

The default value for chord separator and pattern index separator is ,.
This is not good because it prevents to pass a chord as a variable to a function or pattern call.
Another reason: It makes it harder for the parser to distinguish between a chord and a sound effect pipeline (#28).

So the chord and index pattern separators should be changed either to ; or /.
; would look pretty similar while / would be more familiar to alda programmers.

This is a breaking change, and it includes:

  • updating the tutorial on the website
  • updating the readme
  • updating the examples
  • updating a lot of unit tests
  • re-testing the examples in the tutorial
  • re-testing the examples in the readme
  • jumping to a new version (1.6.0) - because of the breaking change

It should be done in the same branch as #28 - because #28 is so cool that it deserves to be published with a new version number.

@truj truj self-assigned this Nov 28, 2023
@truj truj added the midicapl For changes in the MidicaPL language label Nov 28, 2023
truj added a commit that referenced this issue Dec 9, 2023
- change both separators from ',' to '/'
- fixes #83
@truj
Copy link
Owner Author

truj commented Dec 27, 2023

It doesn't make any sense to use a different character for chord separator and pattern index separator.
They should be united.

truj added a commit that referenced this issue Dec 27, 2023
- removed PATTERN_INDEX_SEP completely
- #83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
midicapl For changes in the MidicaPL language
Projects
None yet
Development

No branches or pull requests

1 participant