Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Have most basic translations in the core package? #4

Open
amenk opened this issue Nov 2, 2019 · 5 comments
Open

Discussion: Have most basic translations in the core package? #4

amenk opened this issue Nov 2, 2019 · 5 comments

Comments

@amenk
Copy link

amenk commented Nov 2, 2019

I think there is no need to replicate most translations in the trotro-app - they could be stored in the core app and some overwritten in the specific apps.

Is that possible?

@amenk
Copy link
Author

amenk commented Nov 3, 2019

I think we should have the app name translations and the city name translations in the trotro app and then translations with placeholders in the trufi_core.
Problem might be, that we need to inject the translations from the trotro app into trufi_core - that might be a bit messy, but should work.

Is it worth it?

@mdoelker @RaimundWege

@amenk
Copy link
Author

amenk commented Nov 3, 2019

I have a PoC for this ...

@amenk
Copy link
Author

amenk commented Nov 6, 2019

Proof of concept turns out to not really work; I cannot dynamically switch the languages / the core translations are no longer loaded

@mdoelker
Copy link
Contributor

Sorry for not reacting earlier. Yeah the split approach makes this a bit hard. Have you got something working in the end or do you continue to inject if from the outer app?

@amenk
Copy link
Author

amenk commented Dec 28, 2019

I did not succeed ... currently we keep the full translations in YeneGuzo app ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants