Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trufflehog fails to parse localized timestamp #3338

Open
svenXY opened this issue Sep 26, 2024 · 3 comments
Open

trufflehog fails to parse localized timestamp #3338

svenXY opened this issue Sep 26, 2024 · 3 comments
Labels

Comments

@svenXY
Copy link

svenXY commented Sep 26, 2024

TruffleHog Version

trufflehog 3.82.5

Expected Behavior

trufflehog should parse localized timestamps correctly

Actual Behavior

2024-09-26T09:46:14+02:00	error	trufflehog	failed to parse commit date	
{"source_manager_worker_id": "wAMwt", "unit": "./my_repo_dir", "unit_kind": "dir", 
"repo": "[email protected]:/some/repo.git", "commit": "3ec15209b4d1c854258f7d9ebb05cbbfbc3562fb", "latestState": "AuthorDateLine", 
"error": "parsing time \"Mo Sep 28 07:59:21 2020 +0000\" as \"Mon Jan 2 15:04:05 2006 -0700\": cannot parse \"Mo Sep 28 07:59:21 2020 +0000\" as \"Mon\""}

This is a german localized timestamp. trufflehog then reports found issues as following:

Found unverified result 🐷🔑❓
[...]
Line: 23
Repository: ...
Timestamp: 0001-01-01 00:00:00 +0000

Environment

  • OS: macOS
  • Version 14.7

Additional Context

my LANG is at de_DE.UTF-8, however, setting this to C or en_US.UTF-8 changes nothing.

I ran this against a local repo with trufflehog git file://./my_repo_diras well as against its remote on gitlab with identical results

However, running tools like git, lazygit or tig locally work fine, e.g.

LANG=C git show 3ec15209b4d1c854258f7d9ebb05cbbfbc3562fb

commit 3ec15209b4d1c854258f7d9ebb05cbbfbc3562fb
Author: Me <[email protected]>
Date:   Mon Sep 28 09:59:21 2020

same with LANG set to en_US.UTF-8 or similar.

Maybe I'm forgetting to configure something here, but if so, I failed to find documentation or other issues regarding this.

@svenXY svenXY added the bug label Sep 26, 2024
@svenXY
Copy link
Author

svenXY commented Sep 30, 2024

git cat-file -p 3ec15209b4d1c854258f7d9ebb05cbbfbc3562fb

tree 27a3ef59079f6673bd5286e554b5647dfe4a314e
author H., Sven - D010101 <[email protected]> 1601279961 +0000
committer H., Sven - D010101 <[email protected]> 1601279961 +0000

git does not have an locale either it seems

@TimatGDC
Copy link

TimatGDC commented Oct 4, 2024

Same issue here

@svenXY
Copy link
Author

svenXY commented Nov 25, 2024

Hi,

I'm not a go developer, but I downloaded the code and ran the tests and it also fails there:

[...]
?   	github.com/trufflesecurity/trufflehog/v3/pkg/tui/sources/gitlab	[no test files]
--- FAIL: TestSource_Scan (0.09s)
    git_test.go:29: failed to access secret: failed to access secret version: rpc error: code = Unauthenticated desc = transport: per-RPC creds failed due to error: auth: "invalid_grant" "Bad Request"
2024-11-25T10:04:04+01:00	info-0	context	scanning repo	{"repo": "https://github.com/dustin-decker/secretsandstuff.git"}
2024-11-25T10:04:04+01:00	error	context	failed to parse commit date	{"repo": "https://github.com/dustin-decker/secretsandstuff.git", "commit": "70001020fab32b1fcf2f1f0e5c66424eae649826", "latestState": "AuthorDateLine", "error": "parsing time \"Mo M\\xc3\\xa4r 15 23:27:16 2021 -0700\" as \"Mon Jan 2 15:04:05 2006 -0700\": cannot parse \"Mo M\\xc3\\xa4r 15 23:27:16 2021 -0700\" as \"Mon\""}
2024-11-25T10:04:04+01:00	error	context	failed to parse commit date	{"repo": "https://github.com/dustin-decker/secretsandstuff.git", "commit": "a6f8aa55736d4a85be31a0048a4607396898647a", "latestState": "AuthorDateLine", "error": "parsing time \"Do Jun 25 21:56:35 2020 -0700\" as \"Mon Jan 2 15:04:05 2006 -0700\": cannot parse \"Do Jun 25 21:56:35 2020 -0700\" as \"Mon\""}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants