From fcfc2d45a1660aa3a9b148e0400b89fa14c3cabd Mon Sep 17 00:00:00 2001 From: Vladislav Trotsenko Date: Tue, 16 Aug 2022 11:22:39 +0200 Subject: [PATCH] Technical/Update development dependencies (#225) * Updated gemspecs, circleci config * Updated rubocop/codeclimate configs * Updated version, changelog --- .circleci/config.yml | 2 +- .circleci/gemspec_compatible | 6 +- .circleci/gemspec_latest | 16 +- .codeclimate.yml | 2 +- .rubocop.yml | 414 +---------------------------------- CHANGELOG.md | 8 + lib/truemail/version.rb | 2 +- truemail.gemspec | 6 +- 8 files changed, 37 insertions(+), 419 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index ca16c70..c1f52ff 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -122,7 +122,7 @@ jobs: - checkout - <<: *use_compatible_gemspec - ruby/install-deps: - bundler-version: "2.3.14" + bundler-version: "2.3.20" with-cache: false path: './vendor/custom_bundle' - <<: *install_system_dependencies diff --git a/.circleci/gemspec_compatible b/.circleci/gemspec_compatible index 6a26c0e..265ea78 100644 --- a/.circleci/gemspec_compatible +++ b/.circleci/gemspec_compatible @@ -31,12 +31,12 @@ Gem::Specification.new do |spec| spec.add_runtime_dependency 'simpleidn', '~> 0.2.1' - spec.add_development_dependency 'dns_mock', '~> 1.5', '>= 1.5.3' + spec.add_development_dependency 'dns_mock', '~> 1.5', '>= 1.5.4' spec.add_development_dependency 'ffaker', '~> 2.21' spec.add_development_dependency 'json_matchers', '~> 0.11.1' spec.add_development_dependency 'rake', '~> 13.0', '>= 13.0.6' spec.add_development_dependency 'rspec', '~> 3.11' - spec.add_development_dependency 'smtp_mock', '~> 1.1' + spec.add_development_dependency 'smtp_mock', '~> 1.2', '>= 1.2.1' spec.add_development_dependency 'truemail-rspec', '~> 0.9.1' - spec.add_development_dependency 'webmock', '~> 3.14' + spec.add_development_dependency 'webmock', '~> 3.17', '>= 3.17.1' end diff --git a/.circleci/gemspec_latest b/.circleci/gemspec_latest index 2282c13..8a288e1 100644 --- a/.circleci/gemspec_latest +++ b/.circleci/gemspec_latest @@ -32,21 +32,21 @@ Gem::Specification.new do |spec| spec.add_runtime_dependency 'net-smtp', '~> 0.3.1' spec.add_runtime_dependency 'simpleidn', '~> 0.2.1' - spec.add_development_dependency 'bundler-audit', '~> 0.9.0.1' - spec.add_development_dependency 'dns_mock', '~> 1.5', '>= 1.5.3' + spec.add_development_dependency 'bundler-audit', '~> 0.9.1' + spec.add_development_dependency 'dns_mock', '~> 1.5', '>= 1.5.4' spec.add_development_dependency 'fasterer', '~> 0.10.0' spec.add_development_dependency 'ffaker', '~> 2.21' spec.add_development_dependency 'json_matchers', '~> 0.11.1' spec.add_development_dependency 'overcommit', '~> 0.59.1' - spec.add_development_dependency 'pry-byebug', '~> 3.9' + spec.add_development_dependency 'pry-byebug', '~> 3.10' spec.add_development_dependency 'rake', '~> 13.0', '>= 13.0.6' spec.add_development_dependency 'reek', '~> 6.1', '>= 6.1.1' spec.add_development_dependency 'rspec', '~> 3.11' - spec.add_development_dependency 'rubocop', '~> 1.30' - spec.add_development_dependency 'rubocop-performance', '~> 1.14' - spec.add_development_dependency 'rubocop-rspec', '~> 2.11', '>= 2.11.1' + spec.add_development_dependency 'rubocop', '~> 1.35' + spec.add_development_dependency 'rubocop-performance', '~> 1.14', '>= 1.14.3' + spec.add_development_dependency 'rubocop-rspec', '~> 2.12', '>= 2.12.1' spec.add_development_dependency 'simplecov', '~> 0.21.2' - spec.add_development_dependency 'smtp_mock', '~> 1.1' + spec.add_development_dependency 'smtp_mock', '~> 1.2', '>= 1.2.1' spec.add_development_dependency 'truemail-rspec', '~> 0.9.1' - spec.add_development_dependency 'webmock', '~> 3.14' + spec.add_development_dependency 'webmock', '~> 3.17', '>= 3.17.1' end diff --git a/.codeclimate.yml b/.codeclimate.yml index 3e8853c..157d601 100644 --- a/.codeclimate.yml +++ b/.codeclimate.yml @@ -7,7 +7,7 @@ checks: plugins: rubocop: enabled: true - channel: rubocop-1-30 + channel: rubocop-1-35 reek: enabled: true diff --git a/.rubocop.yml b/.rubocop.yml index 26a4f41..5e6074d 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -6,6 +6,9 @@ AllCops: DisplayCopNames: true DisplayStyleGuide: true TargetRubyVersion: 2.5 + NewCops: enable + +# Metrics --------------------------------------------------------------------- Metrics/ClassLength: Max: 150 @@ -22,6 +25,8 @@ Metrics/CyclomaticComplexity: Metrics/PerceivedComplexity: Enabled: false +# Naming ---------------------------------------------------------------------- + Naming/VariableNumber: Enabled: false @@ -31,8 +36,7 @@ Naming/RescuedExceptionsVariableName: Naming/InclusiveLanguage: Enabled: false -Naming/BlockForwarding: - Enabled: true +# Style ----------------------------------------------------------------------- Style/Documentation: Enabled: false @@ -46,170 +50,7 @@ Style/EmptyCaseCondition: Style/RescueStandardError: Enabled: false -Style/AccessorGrouping: - Enabled: true - -Style/ArrayCoercion: - Enabled: true - -Style/BisectedAttrAccessor: - Enabled: true - -Style/CaseLikeIf: - Enabled: true - -Style/ExplicitBlockArgument: - Enabled: true - -Style/ExponentialNotation: - Enabled: true - -Style/GlobalStdStream: - Enabled: true - -Style/HashAsLastArrayItem: - Enabled: true - -Style/HashEachMethods: - Enabled: true - -Style/HashLikeCase: - Enabled: true - -Style/HashTransformKeys: - Enabled: true - -Style/HashTransformValues: - Enabled: true - -Style/OptionalBooleanParameter: - Enabled: true - -Style/RedundantAssignment: - Enabled: true - -Style/RedundantFetchBlock: - Enabled: true - -Style/RedundantFileExtensionInRequire: - Enabled: true - -Style/RedundantRegexpCharacterClass: - Enabled: true - -Style/RedundantRegexpEscape: - Enabled: true - -Style/SingleArgumentDig: - Enabled: true - -Style/SlicingWithRange: - Enabled: true - -Style/StringConcatenation: - Enabled: true - -Style/CombinableLoops: - Enabled: true - -Style/KeywordParametersOrder: - Enabled: true - -Style/RedundantSelfAssignment: - Enabled: true - -Style/SoleNestedConditional: - Enabled: true - -Style/ClassEqualityComparison: - Enabled: true - -Style/ArgumentsForwarding: - Enabled: true - -Style/CollectionCompact: - Enabled: true - -Style/DocumentDynamicEvalDefinition: - Enabled: true - -Style/NegatedIfElseCondition: - Enabled: true - -Style/NilLambda: - Enabled: true - -Style/SwapValues: - Enabled: true - -Style/RedundantArgument: - Enabled: true - -Style/HashExcept: - Enabled: true - -Style/EndlessMethod: - Enabled: true - -Style/IfWithBooleanLiteralBranches: - Enabled: true - -Style/HashConversion: - Enabled: true - -Style/StringChars: - Enabled: true - -Style/InPatternThen: - Enabled: true - -Style/MultilineInPatternThen: - Enabled: true - -Style/QuotedSymbols: - Enabled: true - -Style/RedundantSelfAssignmentBranch: - Enabled: true - -Style/NumberedParameters: - Enabled: true - -Style/NumberedParametersLimit: - Enabled: true - -Style/SelectByRegexp: - Enabled: true - -Style/OpenStructUse: - Enabled: true - -Style/FileRead: - Enabled: true - -Style/FileWrite: - Enabled: true - -Style/MapToHash: - Enabled: true - -Style/FetchEnvVar: - Enabled: true - -Style/NestedFileDirname: - Enabled: true - -Style/ObjectThen: - Enabled: true - -Style/RedundantInitialize: - Enabled: true - -Style/EnvHome: - Enabled: true - -Style/MapCompactWithConditionalBlock: - Enabled: true +# Layout ---------------------------------------------------------------------- Layout/LineLength: Max: 140 @@ -233,164 +74,18 @@ Layout/ClassStructure: Layout/EmptyLineAfterGuardClause: Enabled: false -Layout/SpaceAroundMethodCallOperator: - Enabled: true - -Layout/EmptyLinesAroundAttributeAccessor: - Enabled: true - -Layout/BeginEndAlignment: - Enabled: true - -Layout/SpaceBeforeBrackets: - Enabled: true - -Layout/LineEndStringConcatenationIndentation: - Enabled: true +# Lint ------------------------------------------------------------------------ Lint/NonDeterministicRequireOrder: Enabled: false -Lint/BinaryOperatorWithIdenticalOperands: - Enabled: true - -Lint/DeprecatedOpenSSLConstant: - Enabled: true - -Lint/DuplicateElsifCondition: - Enabled: true - -Lint/DuplicateRescueException: - Enabled: true - -Lint/EmptyConditionalBody: - Enabled: true - -Lint/FloatComparison: - Enabled: true - -Lint/MissingSuper: - Enabled: false - -Lint/MixedRegexpCaptureTypes: - Enabled: true - -Lint/OutOfRangeRegexpRef: - Enabled: true - -Lint/RaiseException: - Enabled: true - -Lint/SelfAssignment: - Enabled: true - -Lint/StructNewOverride: - Enabled: true - -Lint/TopLevelReturnWithArgument: - Enabled: true - -Lint/UnreachableLoop: - Enabled: true - -Lint/ConstantDefinitionInBlock: - Enabled: true - -Lint/DuplicateRequire: - Enabled: true - -Lint/EmptyFile: - Enabled: true - -Lint/IdentityComparison: - Enabled: true - -Lint/TrailingCommaInAttributeDeclaration: - Enabled: true - -Lint/UselessMethodDefinition: - Enabled: true - -Lint/UselessTimes: - Enabled: true - -Lint/HashCompareByIdentity: - Enabled: true - -Lint/RedundantSafeNavigation: - Enabled: true - -Lint/DuplicateBranch: - Enabled: true - -Lint/DuplicateRegexpCharacterClassElement: - Enabled: true - -Lint/EmptyBlock: - Enabled: true - -Lint/EmptyClass: - Enabled: true - Lint/NoReturnInBeginEndBlocks: Enabled: false -Lint/ToEnumArguments: - Enabled: true - -Lint/UnmodifiedReduceAccumulator: - Enabled: true - -Lint/UnexpectedBlockArity: - Enabled: true - -Lint/AmbiguousAssignment: - Enabled: true - -Lint/DeprecatedConstants: - Enabled: true - -Lint/LambdaWithoutLiteralBlock: - Enabled: true - -Lint/RedundantDirGlobSort: - Enabled: true - -Lint/NumberedParameterAssignment: - Enabled: true - -Lint/OrAssignmentToConstant: - Enabled: true - -Lint/SymbolConversion: - Enabled: true - -Lint/TripleQuotes: - Enabled: true - -Lint/EmptyInPattern: - Enabled: true - -Lint/AmbiguousRange: - Enabled: true - -Lint/AmbiguousOperatorPrecedence: - Enabled: true - -Lint/IncompatibleIoSelectWithFiberScheduler: - Enabled: true - -Lint/RequireRelativeSelfPath: - Enabled: true - -Lint/UselessRuby2Keywords: - Enabled: true +Lint/MissingSuper: + Enabled: false -Lint/RefinementImportMethods: - Enabled: true - -Gemspec/DateAssignment: - Enabled: true +# Gemspec --------------------------------------------------------------------- Gemspec/RequireMFA: Enabled: false @@ -398,68 +93,7 @@ Gemspec/RequireMFA: Gemspec/RubyVersionGlobalsUsage: Enabled: false -Gemspec/DeprecatedAttributeAssignment: - Enabled: true - -Security/IoMethods: - Enabled: true - -Security/CompoundHash: - Enabled: true - -Performance/AncestorsInclude: - Enabled: true - -Performance/BigDecimalWithNumericArgument: - Enabled: true - -Performance/RedundantSortBlock: - Enabled: true - -Performance/RedundantStringChars: - Enabled: true - -Performance/ReverseFirst: - Enabled: true - -Performance/SortReverse: - Enabled: true - -Performance/Squeeze: - Enabled: true - -Performance/StringInclude: - Enabled: true - -Performance/Sum: - Enabled: true - -Performance/BlockGivenWithExplicitBlock: - Enabled: true - -Performance/CollectionLiteralInLoop: - Enabled: true - -Performance/ConstantRegexp: - Enabled: true - -Performance/MethodObjectAsBlock: - Enabled: true - -Performance/RedundantEqualityComparisonBlock: - Enabled: true - -Performance/RedundantSplitRegexpArgument: - Enabled: true - -Performance/MapCompact: - Enabled: true - -Performance/ConcurrentMonotonicTime: - Enabled: true - -Performance/StringIdentifierArgument: - Enabled: true +# RSpec ----------------------------------------------------------------------- RSpec/ExampleLength: Enabled: false @@ -491,32 +125,8 @@ RSpec/MultipleMemoizedHelpers: RSpec/StubbedMock: Enabled: false -RSpec/IdenticalEqualityAssertion: - Enabled: true - -RSpec/Rails/AvoidSetupHook: - Enabled: true - -RSpec/ExcessiveDocstringSpacing: - Enabled: true - -RSpec/SubjectDeclaration: - Enabled: true - -RSpec/FactoryBot/SyntaxMethods: - Enabled: true - RSpec/SubjectStub: Enabled: false -RSpec/BeEq: - Enabled: true - -RSpec/BeNil: - Enabled: true - RSpec/VerifiedDoubleReference: Enabled: false - -RSpec/ChangeByZero: - Enabled: true diff --git a/CHANGELOG.md b/CHANGELOG.md index b16bdeb..46e43e3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,14 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## [2.7.4] - 2022.08.16 + +### Updated + +- Updated gemspecs, circleci config +- Updated rubocop/codeclimate configs +- Updated gem version + ## [2.7.3] - 2022.05.31 ### Updated diff --git a/lib/truemail/version.rb b/lib/truemail/version.rb index 00e566d..2d74864 100644 --- a/lib/truemail/version.rb +++ b/lib/truemail/version.rb @@ -1,5 +1,5 @@ # frozen_string_literal: true module Truemail - VERSION = '2.7.3' + VERSION = '2.7.4' end diff --git a/truemail.gemspec b/truemail.gemspec index 9d07762..706a13f 100644 --- a/truemail.gemspec +++ b/truemail.gemspec @@ -32,12 +32,12 @@ Gem::Specification.new do |spec| spec.add_runtime_dependency 'net-smtp', '~> 0.3.1' if ::RUBY_VERSION >= '3.1.0' spec.add_runtime_dependency 'simpleidn', '~> 0.2.1' - spec.add_development_dependency 'dns_mock', '~> 1.5', '>= 1.5.3' + spec.add_development_dependency 'dns_mock', '~> 1.5', '>= 1.5.4' spec.add_development_dependency 'ffaker', '~> 2.21' spec.add_development_dependency 'json_matchers', '~> 0.11.1' spec.add_development_dependency 'rake', '~> 13.0', '>= 13.0.6' spec.add_development_dependency 'rspec', '~> 3.11' - spec.add_development_dependency 'smtp_mock', '~> 1.1' + spec.add_development_dependency 'smtp_mock', '~> 1.2', '>= 1.2.1' spec.add_development_dependency 'truemail-rspec', '~> 0.9.1' - spec.add_development_dependency 'webmock', '~> 3.14' + spec.add_development_dependency 'webmock', '~> 3.17', '>= 3.17.1' end