-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test on Julia v1.10 (and possibly 1.9) #26
Comments
We were just about to update the CI to Julia v1.9 in #22. |
No, just move directly to v1.10 unless you find hard issues that we need to solve in Trixi.jl first. |
Running the test on Julia v1.10 some of the sensitive (mostly well-balanced) tests fail just outside their tolerance, see #29 Does anyone know of any changes that could have triggered this difference? Since the results are still correct, I would suggest that we just loosen the tolerance a bit. |
I have seen similar differences in SummationByPartsOperators.jl. I guess that they are just caused by some floating point differences coming from different LLVM versions, but I am not 100% certain. However, I would be fine with following your strategy (which I have done also in SummationByPartsOperators.jl). |
I think I've seen similar floating point differences in trixi-framework/Trixi.jl#1562, where some tests apparently fail due to small changes in the error norms. |
It makes sense that the problem would be caused by some floating point differences as these tests are very sensitive to this. The failing tests can also be reproduced when I run them on my local machine. |
IMHO the main tests should be run on the most recent stable release, plus a smaller testset possibly on older versions to verify that they are still supported.
The text was updated successfully, but these errors were encountered: