Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viscous semidiscretizations #704

Closed
jlchan opened this issue Jul 8, 2021 · 8 comments
Closed

viscous semidiscretizations #704

jlchan opened this issue Jul 8, 2021 · 8 comments

Comments

@jlchan
Copy link
Contributor

jlchan commented Jul 8, 2021

What's the current status for viscous semidiscretizations in Trixi (e.g, for compressible Navier-Stokes + BR1 discretization)? I only remember seeing a message in Slack a while back.

@ranocha
Copy link
Member

ranocha commented Jul 8, 2021

There's some WIP in #378. However, it's not finished and it isn't clear whether that's the approach we really want to use in the future. The only way to find that out seems to be to invest some work into it such that it does the job for now, merge it, mark it as experimental, and see how it's going.

@jlchan
Copy link
Contributor Author

jlchan commented Jul 8, 2021

Thanks! I was wondering how to cleanly prescribe gradient BCs. Seems like an open question still based on #378 (comment)

@sloede
Copy link
Member

sloede commented Jul 8, 2021

Yes, it is :-/ The only sensible way forward seems to be what @ranocha said above:

The only way to find that out seems to be to invest some work into it such that it does the job for now, merge it, mark it as experimental, and see how it's going.

@jlchan
Copy link
Contributor Author

jlchan commented Jun 1, 2023

Should we close this now and update #891?

@sloede
Copy link
Member

sloede commented Jun 1, 2023

Should we close this now and update #891?

Sounds good to me! We should probably also close #378, since it's been superseded by the new approach and I don't really see us going back to that approach...

@ranocha
Copy link
Member

ranocha commented Jun 1, 2023

Sounds good to me. We should also have another issue tracking this, e.g., other numerical fluxes for the second-order terms, don't we?

@jlchan
Copy link
Contributor Author

jlchan commented Jun 1, 2023

Do you mean #1147?

@ranocha
Copy link
Member

ranocha commented Jun 1, 2023

Yes. Let's close this issue here and continue with the others

@jlchan jlchan closed this as completed Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants