-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatting is ugly sometimes #1758
Comments
I didn't just create this issue for fun. Here is a fix for the second part: This changes the second part to - function gradient_variable_transformation(::CompressibleNavierStokesDiffusion2D{
- GradientVariablesPrimitive
- })
+ function gradient_variable_transformation(::CompressibleNavierStokesDiffusion2D{GradientVariablesPrimitive})
cons2prim
end
- function gradient_variable_transformation(::CompressibleNavierStokesDiffusion2D{
- GradientVariablesEntropy
- })
+ function gradient_variable_transformation(::CompressibleNavierStokesDiffusion2D{GradientVariablesEntropy}) When applied to all of |
Nice, thanks! Is your PR to JuliaFormatter.jl already accepted and released? |
It's merged, but not yet released. |
Now it's released and #1759 is ready to merge. |
See my comment above. I only fixed the second problem. |
This is ugly:
Trixi.jl/src/equations/equations.jl
Lines 418 to 424 in d7e1f74
This as well:
Trixi.jl/src/equations/compressible_navier_stokes_2d.jl
Lines 133 to 140 in d7e1f74
This could probably be fixed in JuliaFormatter.
The text was updated successfully, but these errors were encountered: