Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Limitation with Dirichlet BCs #1219

Closed
cmhamel opened this issue Sep 17, 2022 · 7 comments · Fixed by #1149
Closed

Possible Limitation with Dirichlet BCs #1219

cmhamel opened this issue Sep 17, 2022 · 7 comments · Fixed by #1149

Comments

@cmhamel
Copy link

cmhamel commented Sep 17, 2022

Hi, first off great framework!

I started brainstorming on using Trixi to map some old grad student code for processing modeling of digital light processing (DLP, it's a light based 3D printing method) after seeing the recent contributions of hyperbolic diffusion and got hung up on the current implementation of Dirichlet BCs in Trixi. The Beer-Lambert law is an equation that shows up in the system of equations I'm interested in which is hyperbolic but with a time derivative assumed to be zero due to the differing time scales of the problem. The Beer-Lambert law (in 1D for simplicity) only has a one BC on the end points of the domain, physically it's the point at which light is penetrating the media. The other end point is free of a BC constraint. It seems that Trixi's Dirichlet BCs currently assumes "symmetric" Dirichlet BCs in the sense that if you have one BC on -x, you need one on +x. Am I correct in thinking this?

I was wondering how deep this convention goes in the framework? Is it hard-coded all the way down? This equation I described is likely a unique case so probably not worth refactoring the framework unless others have expressed similar concerns. I'm mainly curious of the right places to look if I wanted to modify my own local version and open up a discussion if others have ran into this limitation as well.

Craig

@jlchan
Copy link
Contributor

jlchan commented Sep 18, 2022

Hi Craig! While I'm not too familiar with the details of your system, it sounds like you might be looking for boundary_condition_do_nothing at the right endpoint. Does that help?

@cmhamel
Copy link
Author

cmhamel commented Sep 18, 2022

Thanks so much. That definitely does help!

Is this documented and I somehow missed it?

@jlchan
Copy link
Contributor

jlchan commented Sep 18, 2022

Hmm...I'm not sure that it is. I can add one soon. Thanks for bringing that to our attention!

@jlchan
Copy link
Contributor

jlchan commented Sep 18, 2022

Ah, nevermind - my mistake, boundary_condition_do_nothing is still in the dev branch https://github.com/trixi-framework/Trixi.jl/blob/dev/src/basic_types.jl.

We probably won't be merging dev for at least a few weeks, so if you'd like to use boundary_condition_do_nothing, you can just add the routine locally and use it.

@cmhamel
Copy link
Author

cmhamel commented Sep 18, 2022

Thanks @jlchan this was very helpful.

You can close the issue if you'd like, unless y'all would like to use it to track documentation status.

@jlchan
Copy link
Contributor

jlchan commented Sep 18, 2022

Sounds good. I think we can close this once the changes in dev are merged, this so good to keep around for reference.

@jlchan
Copy link
Contributor

jlchan commented Oct 5, 2022

When #1149 is merged, this should be closed

@jlchan jlchan linked a pull request Oct 5, 2022 that will close this issue
@cmhamel cmhamel closed this as completed Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants